Add ILivechatRoomClosedHandler

[shiqimei]

What? ⛵

Closes #188

Why? 🤔

Ref: #188 (comment)

Links 🌎

PS 👀

It also depends on changes in the Rocket.Chat side: RocketChat/Rocket.Chat#15837

[codecov]

Codecov Report

Merging #189 into master will decrease coverage by 2.29%.
The diff coverage is 6.25%.

@@            Coverage Diff            @@
##           master     #189     +/-   ##
=========================================
- Coverage   56.64%   54.34%   -2.3%     
=========================================
  Files          77       69      -8     
  Lines        2560     2462     -98     
  Branches      370      372      +2     
=========================================
- Hits         1450     1338    -112     
- Misses       1110     1124     +14

Impacted Files	Coverage Δ
src/server/accessors/LivechatRead.ts	20% <0%> (-13.34%)	⬇️
src/server/managers/AppListenerManager.ts	4.33% <0%> (-0.18%)	⬇️
src/server/compiler/AppImplements.ts	100% <100%> (ø)	⬆️
src/server/errors/index.ts
src/server/managers/index.ts
src/server/accessors/index.ts
src/server/marketplace/license/index.ts
src/server/compiler/index.ts
src/server/storage/index.ts
src/server/logging/index.ts
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32be2d2...04dafdd. Read the comment docs.

[renatobecker-zz]

Guys!
I just found a problem related to the IVisitor interface.
As you can see here, the fields updatedAt and visitorEmails are not mandatory, but the interface is requiring them as shown below:

export interface IVisitor {
    id?: string;
    token: string;
    username: string;
    updatedAt: Date;
    name: string;
    department?: string;
    phone?: Array<IVisitorPhone>;
    visitorEmails: Array<IVisitorEmail>;
    customFields?: {
        [key: string]: any;
    };
}

What do you guys think about it? Shall we fix it?
Thanks.

[d-gubert]

This is getting kinda hard to manage... In the rich messages we have added one type here as well, and this tends to keep growing. We should think of a way of refactoring this in the future

[renatobecker-zz]

@d-gubert / @lolimay, just a quick question:

The code below is returning undefined when creating a new message, but it's supposed to return the id of the new message, right?

    ...
    const msg = modify.getCreator().startLivechatMessage()
    .setToken(token)
    .setVisitor(visitor)
    .setRoom(room);

    if (text) {
        msg.setText(text);
    }

    if (attachment) {
        msg.addAttachment(attachment);
    }

    return modify.getCreator().finish(msg);

Do you guys see anything wrong with my code?

[d-gubert]

@renatobecker nothing appears wrong with your code. It's weird that the id is not being returned since the implementation seems to be taking that into account 🤔