Remove forever daemon in lieu of plain Upstart on Ubuntu 14 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method of using the forever monitor daemon with upstart failed at being able to write to the pid-file upon reboot. This showed up in Vagrant testing and I believe it has something to do with the fact that we're creating the pidfile manually within the play. I have prior experience with NodeJS+Upstart and it turns out that forever isn't actually necessary at all. With `console log` and `respawn` directives, and an unforked process, Upstart properly tracks the PID (without a pidfile), respawns the process should it die, and logs by default to `/var/log/upstart/rocketchat.log` This changeset removes the following tasks and has the added benefit of simplifying the play overall: - Ensure Forever (NodeJS) is installed [Ubuntu 14] - Check to see if the Rocket.Chat log file is present [Ubuntu 14] - Ensure the Rocket.Chat log file is present [Ubuntu 14] - Ensure the Rocket.Chat pid file is present [Ubuntu 14] The former log-file path has been replaced with a symlink pointing to the new logfile path. This fixes #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method of using the forever monitor daemon with upstart
failed at being able to write to the pid-file upon reboot. This showed
up in Vagrant testing and I believe it has something to do with the fact
that we're creating the pidfile manually within the play.
I have prior experience with NodeJS+Upstart and it turns out that
forever isn't actually necessary at all. With
console logandrespawndirectives, and an unforked process, Upstart properly tracksthe PID (without a pidfile), respawns the process should it die, and
logs by default to
/var/log/upstart/rocketchat.logThis changeset removes the following tasks and has the added benefit of
simplifying the play overall:
The former log-file path has been replaced with a symlink pointing to
the new logfile path.
This fixes #11