Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Feature to deploy previews of pull requests #638

Merged

Conversation

devanshkansagra
Copy link
Contributor

Pull Request Preview Deployment to GitHub Pages

Acceptance Criteria fulfillment

  • Deploy every pull request builds of monorepo to a unique url
  • Remove Deployment when PR is merged and closed

Video/Screenshots

image

.github/workflows/cd-pr.yml Outdated Show resolved Hide resolved
.github/workflows/ci-pr.yml Outdated Show resolved Hide resolved
.github/workflows/ci-pr.yml Outdated Show resolved Hide resolved
.github/workflows/ci-pr.yml Outdated Show resolved Hide resolved
.github/workflows/ci-pr.yml Outdated Show resolved Hide resolved
.github/workflows/pr-cleanup.yml Show resolved Hide resolved
@Spiral-Memory Spiral-Memory added the epic this is a must have feature label Oct 5, 2024
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test build !

@Spiral-Memory Spiral-Memory marked this pull request as draft October 5, 2024 18:32
@devanshkansagra devanshkansagra marked this pull request as ready for review October 6, 2024 06:42
@Spiral-Memory
Copy link
Collaborator

Thank you so much for the contribution, @devanshkansagra.
I truly appreciate the time and effort you put into this PR, as it was a much-needed feature to allow maintainers to test changes visually before merging. Since I worked with you on this, I know how much time, effort, and research went into building and testing it on a dummy repo.

With all good intentions, I am merging it to see if everything works as expected.

Note: We understand the security risks associated with the pull_request_target and workflow_run triggers, and we have done our best to maintain a balance between convenience and security. However, if any security incidents arise due to this, we are ready to revert the changes at any time.

Thanks again, @devanshkansagra. Happy contributing!

@Spiral-Memory Spiral-Memory merged commit ebca321 into RocketChat:develop Oct 6, 2024
4 checks passed
@devanshkansagra devanshkansagra deleted the feat/deploy-pr-previews branch October 23, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic this is a must have feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants