fixed markdown rendering in report message #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spiral-Memory
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
IMO, we should remove showing the message content in the first place so that we don't have to handle large/complex messages here in this small window
@Spiral-Memory thoughts?
|
I think that’s a good idea @sidmohanty11 . Alternatively, we could use an ellipsis style so that when the text reaches the end of the line, it displays '...' instead of the complete message. Both approaches seem fine to me. @smritidoneria , which option do you think would be better for you to implement?" |
|
Both the implementation looks good, we can go @sidmohanty11 approach |
smritidoneria
force-pushed
the
report-fixes
branch
from
ad3f37f
to
309bc89
Compare
|
Hey @smritidoneria |
|
yes, it is ready for review @Spiral-Memory . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
In report message, text shown is appropiate and readable.
Acceptance Criteria fulfillment
Fixes #610
Video/Screenshots
Screen.Recording.2024-07-23.at.12.40.52.PM.mov