Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Preserve RocketChat Message in New and Existing Notion Page #26

Merged
merged 17 commits into from
Aug 30, 2023
Merged

[Feat] Preserve RocketChat Message in New and Existing Notion Page #26

merged 17 commits into from
Aug 30, 2023

Conversation

Nabhag8848
Copy link
Collaborator

@Nabhag8848 Nabhag8848 commented Aug 10, 2023 •
edited
Loading

Issue(s)

Acceptance Criteria fulfillment

  • Create Action Button [ Send to Page , Send to New Page] as Message Box Action
  • Create Modal Send to Notion Page for Sending it to Existing Page
  • Open CreatePageOrRecord Modal for Sending to New Page.
  • Send Message In Thread that Message has been Preserve in X Page with Link

Proposed changes (including videos or screenshots)

Further comments

@Nabhag8848
feat: create record
1d2dd41
@Nabhag8848
feat: create record improved Version
91c5819
@Nabhag8848
fix: Required Property Closing Modal onSubmit with ViewErrors
e089eec
@Nabhag8848
fix: variable naming to missingPropObject
7fe1082
@Nabhag8848
feat: share page
5a51803
@Nabhag8848
fix: Sharing page without selecting with ViewErrors
cce0216
@Nabhag8848
feat: register send to page message action
5055660
@Nabhag8848
feat: Write Message While Creation of Notion Record
59a596c
@Nabhag8848
fix: message attachment to have a quote instead of text
bb031ec
@Nabhag8848
feat: Write Message while Creating Page
98f8747
@Nabhag8848
feat: appendCodeBlock while Creating Message text in Page
9311a85
@Nabhag8848
feat: appendCallOutBlock on Preserving Message
1c94a11
@Nabhag8848
fix: actionbutton to send-to-new-page instead of send-to-page
40c0989
@Nabhag8848
fix: share page to get new created pages
4e10882
@Nabhag8848
feat: created sendMessagePageModal()
09ec9fc
@Nabhag8848
feat: handled sendToNotionPage Action
87d8bfe
@Nabhag8848
feat: handled sendToNotionPage Submit Action
e75a0eb
samad-yar-khan
samad-yar-khan approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nabhag8848 LGTM !

@samad-yar-khan samad-yar-khan merged commit 9859b92 into RocketChat:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samad-yar-khan samad-yar-khan samad-yar-khan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Preserve RocketChat Message in New and Existing Notion Page
2 participants
@Nabhag8848 @samad-yar-khan