[FEAT]: send email & summary as email using slash command. #13

priyanshuharshbodhi1 · 2025-07-12T20:01:45Z

Description

This PR enables user to do following things:

send an email to any email address or any user(s) present on the workspace by tagging them in the slash commmand.
Ex:
- /email send an congratulatory email to priyanshu@gmail.com --> sends email to priyanshu@gmail.com
- /email send an congratulatory email to @priyanshu.harshbodhi and @sing.li --> sends email to sing and priyanshu on their registered emails in RC(in case of more than 1 emails are verified of a user then mail will be send to all of those emails)
User can summarise conversations in channel OR thread send it as email. User can also mention date range and which user's messages to summarise by tagging them)
Ex:
- /email summarise the conversation between @sing.li and @priyanshu.harshbodhi in the last week and send it to @vipin.chaudhary --> summarises the conversation between ONLY sing and priyanshu in last 7 days by extracting messages between only them and sends it email address of vipin
User can edit emails before sending it to recipient(s)
If user types anything which our app cant do or understand then iut shows error response:
Ex:
- /email fhsd foo baar sdhsd ---> app replies: "I can't understand your request. Could you please rephrase it with more details?"

Videos:

Screencast.from.2025-07-13.01-08-05.webm

Screencast.from.2025-07-13.01-06-10.webm

Screencast.from.2025-07-13.02-02-17.webm

… multiple languages

…ing and user notifications

…modal integration

…tionality

…message retrieval and formatting

- remove redundant tools - add extract-attactments tool - extract usernames from emails in prompt

…N formatting in email content

priyanshuharshbodhi1 · 2025-07-12T20:40:28Z

@VipinDevelops PTAL

priyanshuharshbodhi1 · 2025-07-12T21:00:22Z

Current tool calling workflow

…ality, add message configuration constants, and improve prompt formatting

VipinDevelops · 2025-07-14T06:37:53Z

Add more info in this message as discussed earlier

update the message instead of sending new one's

VipinDevelops · 2025-07-14T06:39:34Z

if you have user's name you can also fetch there avatar use that to show in the modal, it would be better UX for sending mail.

VipinDevelops · 2025-07-14T06:43:50Z

src/handlers/ExecuteActionButtonHandler.ts

+            // Retrieve stored email data
+            const emailData = await this.getStoredEmailData(room.id);
+
+            if (!emailData) {


User should get a error message when these error's occur that explain what went wrong.

VipinDevelops · 2025-07-14T06:43:57Z

src/handlers/ExecuteActionButtonHandler.ts

+                throw new Error('Email data not found');
+            }
+
+            if (!triggerId) {


for this too

VipinDevelops · 2025-07-14T06:46:59Z

src/handlers/Handler.ts

+        }
+    }
+
+    public async ProcessNaturalLanguageQuery(query: string): Promise<void> {


To many thing happening in this method refactor it to smaller chunks

VipinDevelops · 2025-07-14T06:47:56Z

src/handlers/Handler.ts

+
+                    fixedArguments = fixedArguments.replace(/("content"\s*:\s*")([^"]*)\n([^"]*?)(")/g, (match, start, content1, content2, end) => {
+                        const fixedContent = (content1 + content2).replace(/\n/g, '\\n').replace(/\r/g, '\\r');
+                        return start + fixedContent + end;
+                    });
+
+                    fixedArguments = fixedArguments.replace(/("content"\s*:\s*")([^"]*"[^"]*?)(")/g, (match, start, content, end) => {
+                        const fixedContent = content.replace(/"/g, '\\"');
+                        return start + fixedContent + end;
+                    });
+
+                    try {
+                        args = JSON.parse(fixedArguments);
+                    } catch (secondParseError) {
+                        resultMessageBuilder.setText(t(Translations.LLM_PARSING_ERROR, this.language));
+                        return this.read.getNotifier().notifyUser(this.sender, resultMessageBuilder.getMessage());
+                    }
+                }
+


what is this piece of code doing to many regex no explanation try to give me some example in comment its hard to understand

I have improved the prompt, now we dont need this regex in this method.

Then why is it still in code ?

VipinDevelops · 2025-07-14T06:48:09Z

src/handlers/Handler.ts

+                }
+
+                // Handle send-email and summarize-and-send-email tools with buttons instead of immediate modal
+                if (toolCall.function.name === 'send-email' || toolCall.function.name === 'summarize-and-send-email') {


don't use string use enums or type

VipinDevelops · 2025-07-14T06:48:21Z

src/handlers/Handler.ts

+                if (toolCall.function.name === 'send-email' || toolCall.function.name === 'summarize-and-send-email') {
+                    let emailData: ISendEmailData;
+
+                    if (toolCall.function.name === 'send-email') {


again no strings

VipinDevelops · 2025-07-14T06:49:52Z

src/handlers/Handler.ts

+                            }
+
+                            // Format messages for summarization
+                            const formattedMessages = messageService.formatMessagesForSummary(messages);


Put all the formatted message thing in different file.

VipinDevelops · 2025-07-14T06:50:04Z

src/handlers/Handler.ts

+                    // Show simplified email ready message with buttons
+                    const block = this.modify.getCreator().getBlockBuilder();
+
+                    const messageText = toolCall.function.name === 'summarize-and-send-email' 


again no string

VipinDevelops · 2025-07-14T06:50:52Z

src/handlers/Handler.ts

+                );
+
+                // Create formatted message showing the tool execution result
+                const block = this.modify.getCreator().getBlockBuilder();


this whole method is TOO long it should be a lot smaller divide this in different files and handlers

VipinDevelops · 2025-07-14T06:52:34Z

@priyanshuharshbodhi1 make the requested changes.

priyanshuharshbodhi1 · 2025-07-14T19:12:12Z

Add more info in this message as discussed earlier update the message instead of sending new one's

Messages can be updated, Notifications can't be updated once sent. So we will have 2 messages as earlier.

…essage formatting, and additional translation constants for recipient display

VipinDevelops · 2025-07-15T05:09:18Z

Add more info in this message as discussed earlier update the message instead of sending new one's

Messages can be updated, Notifications can't be updated once sent. So we will have 2 messages as earlier.

Then check If we can convert a message to read only message and then first send a message and then update it and then make it read only.

priyanshuharshbodhi1 · 2025-07-17T02:07:14Z

Add more info in this message as discussed earlier update the message instead of sending new one's

Messages can be updated, Notifications can't be updated once sent. So we will have 2 messages as earlier.

Then check If we can convert a message to read only message and then first send a message and then update it and then make it read only.

I checked it we cant do that.

…er and MessageFormatter classes

VipinDevelops · 2025-07-17T07:39:19Z

Add more info in this message as discussed earlier update the message instead of sending new one's

Messages can be updated, Notifications can't be updated once sent. So we will have 2 messages as earlier.

Then check If we can convert a message to read only message and then first send a message and then update it and then make it read only.

I checked it we cant do that.

any other alternative to this ? we shouldn't give this bad UX try to find some way around it and share you research.

priyanshuharshbodhi1 · 2025-07-18T18:20:22Z

Add more info in this message as discussed earlier update the message instead of sending new one's

Messages can be updated, Notifications can't be updated once sent. So we will have 2 messages as earlier.

Then check If we can convert a message to read only message and then first send a message and then update it and then make it read only.

I checked it we cant do that.

any other alternative to this ? we shouldn't give this bad UX try to find some way around it and share you research.

No I didn't find something else for it, I also had a discussion with App.Receipt.Processor's mentee, he is also using similar method.

…rmatting interfaces, and enhance translation constants for improved user feedback

priyanshuharshbodhi1 · 2025-07-18T20:46:17Z

Hey @VipinDevelops PTAL!

Screencast.from.2025-07-19.02-12-42.webm

…andling with username extraction for display, and improve message formatting with avatars in SendEmailModal

priyanshuharshbodhi1 · 2025-07-18T22:30:25Z

I have updated the PR with changes you mentioned.

VipinDevelops · 2025-07-19T04:18:44Z

Add more info in this message as discussed earlier update the message instead of sending new one's

Messages can be updated, Notifications can't be updated once sent. So we will have 2 messages as earlier.

Then check If we can convert a message to read only message and then first send a message and then update it and then make it read only.

I checked it we cant do that.

any other alternative to this ? we shouldn't give this bad UX try to find some way around it and share you research.

No I didn't find something else for it, I also had a discussion with App.Receipt.Processor's mentee, he is also using similar method.

Alright then maybe this is one of few cases where app engine fails

VipinDevelops · 2025-07-19T04:22:25Z

Hey @VipinDevelops PTAL!

Screencast.from.2025-07-19.02-12-42.webm

We can improve the messages you show for AI thinking it should be just "thinking"

Remove " AI response" from second message
It makes it feel like a robot not a assistant which we aim to show

How you are handling cases when there would be alot of email and images ? There should be a threshold

Like above 3 we only show images
And above 10 we just show 3 images and one count like +5 after images check some examples you'll understand what I mean

Current modal image UI might break in case of multiple mails

VipinDevelops

PR is improved but still needs some changes
@priyanshuharshbodhi1

VipinDevelops · 2025-07-19T04:24:04Z

src/constants/prompts.ts

@@ -0,0 +1,157 @@
+export const LlmPrompts = {


This is a really long prompt divided this into seperate parts to make it easy to use

Like one constant name response example so on after that spread it in here.

VipinDevelops · 2025-07-19T04:24:28Z

src/constants/prompts.ts

+
+    ---
+
+    CRITICAL JSON REQUIREMENTS:


This will be common in all AI prompt make a constant for this

VipinDevelops · 2025-07-19T04:26:06Z

src/handlers/Handler.ts

-            messageBuilder.setText(
-                t(Translations.ERROR_PROCESSING_LOGIN, this.language, { error: error.message })
-            );
+            this.app.getLogger().error('Login processing error:', error);


Create a common error handlerand use that in all the places

VipinDevelops · 2025-07-19T04:26:26Z

src/handlers/Handler.ts

+            this.app.getLogger().error('Logout preparation error:', error);
+
+            // Provide user-friendly error message
+            let userMessage: string;


Common error handler

VipinDevelops · 2025-07-19T04:26:39Z

src/handlers/Handler.ts

@@ -351,7 +387,17 @@ export class Handler implements IHandler {
                .setRoom(this.room)
                .setGroupable(false);

-            messageBuilder.setText(t(Translations.CONFIG_ERROR, this.language, { error: error.message }));
+            // Categorize error and provide user-friendly message


Same error handler

VipinDevelops · 2025-07-19T04:26:51Z

src/handlers/Handler.ts

-                t(Translations.REPORT_ERROR, this.language, { error: error.message })
+
+            // Provide user-friendly error message based on error type
+            let userMessage: string;


Here as well

VipinDevelops · 2025-07-19T04:27:22Z

src/handlers/Handler.ts

+                .setGroupable(false);
+
+            // Provide specific error message based on error type
+            let userMessage: string;


Error thing

- implement centralized error handling across the app - divide tool calling prompt for future use.

priyanshuharshbodhi1 · 2025-07-20T14:58:39Z

@VipinDevelops, PTAL, I have made all the changes.

I will raise the "Change LLM" PR once you merge this one. Or make it draft one.

… put comma in between

VipinDevelops · 2025-07-21T07:52:08Z

@VipinDevelops, PTAL, I have made all the changes.

I will raise the "Change LLM" PR once you merge this one. Or make it draft one.

You can raise that PR right now and the branch of that can be from this branch similar to how we did previously

VipinDevelops · 2025-07-21T07:52:37Z

Don't wait for Merges to make PR or stop working because of that PR will only get merged when its complete and tested.

VipinDevelops · 2025-07-21T07:53:05Z

package-lock.json

@@ -469,6 +469,7 @@
            "version": "3.0.0-beta2",
            "resolved": "https://registry.npmjs.org/@msgpack/msgpack/-/msgpack-3.0.0-beta2.tgz",
            "integrity": "sha512-y+l1PNV0XDyY8sM3YtuMLK5vE3/hkfId+Do8pLo/OPxfxuFAUwcGz3oiiUuV46/aBpwTzZ+mRWVMtlSKbradhw==",
+            "deprecated": "too old",


Did you installed new package or what why we have this ?

Nope. the authers of the package may have marked this version of package "too old" and thus it shows it here.

VipinDevelops · 2025-07-21T07:54:28Z

src/definition/lib/IEmailUtils.ts

+    text: string;
+}
+
+export interface ISummarizeParams {


add comments why we have all things optional

Because, the query from user may or may not those fields:

if it contains start and end date for conversation then LLM responds with those. in that case days will be optional

if user mentioned conversation from last 5 days then LLM responds with 5 in days field.

if user didn't mentioned any date in the query then all three( days, start date, end date) would be empty and in that case app will just summarise last 25 messages in the channel or thread.

for person, if user mentioned any person(s) in the query then app will only summarise messages of that person(s).

if user mentioned like he wants the summary in bullet format then summary will be in bullett format. If nothing is mentioned then the summary will be generic

VipinDevelops · 2025-07-21T07:54:36Z

src/definition/lib/IEmailUtils.ts

+    format?: 'bullet' | 'paragraph' | 'detailed' | 'brief';
+}
+
+export interface ISummarizeAndSendEmailData {


here as well

same for here

VipinDevelops · 2025-07-21T07:55:36Z

src/definition/lib/ToolInterfaces.ts

+    };
+}
+
+export interface ILLMResponse {


LLM response from different providers would be different right? you have to define for all the different provider you been using

Nope, this interface structure will be same for all LLMs.

VipinDevelops · 2025-07-21T07:58:47Z

src/handlers/ExecuteBlockActionHandler.ts

-            // Get user's preferred email provider from their personal settings
+            const data = await this.read.getPersistenceReader().readByAssociation(association);
+
+            // Handle both array and single object responses


good are we handling any case in which LLM provide a response that don't fit any of the type swe defined because of hallucination

its explicitely mentioned in the prompt that it should respond with only tool mentioned in the prompt and if no tool fits for the query enterd by user then app gives messsage: I can't understand your request. Please rewrite your query with more details.

If LLM halicunates and dont responds with plain text instead of json or incorrect json then it shows: LLM parse error in message

priyanshuharshbodhi1 · 2025-07-21T16:25:57Z

Don't wait for Merges to make PR or stop working because of that PR will only get merged when its complete and tested.

Yes its done 90%.

VipinDevelops · 2025-07-23T08:12:16Z

Don't wait for Merges to make PR or stop working because of that PR will only get merged when its complete and tested.

Yes its done 90%.

all the changes and comments resolved ?

priyanshuharshbodhi1 added 13 commits July 4, 2025 02:58

feat: add LLM prompts for email assistant functionality

3b7cc8d

refactor: simplify command handling logic in CommandUtility

65ae070

feat: enhance email functionality and add LLM configuration

0df081c

feat: introduce Send Email modal and enhance handler interfaces

8255cd9

feat: add tool calling messages and send email modal translations for…

d0b07e4

… multiple languages

feat: implement email sending functionality with enhanced error handl…

a7d6784

…ing and user notifications

feat: add LLM service and tool executor for email functionality with …

a29addd

…modal integration

feat: introduce LLM tool interfaces and update prompts for email func…

a73be90

…tionality

refactor: clean up email handling code and improve error logging

d819b76

fix: outlook cc null error & provider change warning

9d313b0

feat: implement summarize-and-send-email functionality with enhanced …

598aa5e

…message retrieval and formatting

feat:

a5eeec0

- remove redundant tools - add extract-attactments tool - extract usernames from emails in prompt

refactor: remove unused LLM error messages and update prompts for JSO…

8a50172

…N formatting in email content

priyanshuharshbodhi1 added 2 commits July 13, 2025 02:44

feat: enhance message retrieval and error handling for email function…

0691d4e

…ality, add message configuration constants, and improve prompt formatting

fix: login and logout message resending

23e747b

VipinDevelops requested changes Jul 14, 2025

View reviewed changes

VipinDevelops changed the title ~~[FEAT]: send email & summarise conversations and send it as email using slash command.~~ [FEAT]: send email & summary as email using slash command. Jul 14, 2025

feat: enhance email functionality with improved error handling, new m…

94a4151

…essage formatting, and additional translation constants for recipient display

refactor: clean up whitespace and improve message formatting in Handl…

e58a4db

…er and MessageFormatter classes

feat: add new error handling for summary requests, introduce email fo…

bdf2bac

…rmatting interfaces, and enhance translation constants for improved user feedback

update: use format from EmailFormat.ts

d3fcd08

feat: add avatar configuration and utility functions, enhance email h…

c06bc8b

…andling with username extraction for display, and improve message formatting with avatars in SendEmailModal

VipinDevelops requested changes Jul 19, 2025

View reviewed changes

priyanshuharshbodhi1 added 2 commits July 20, 2025 19:22

update: app notification for NL Query.

97c9c83

refactor:

f1869b3

- implement centralized error handling across the app - divide tool calling prompt for future use.

fix: update message formatting to remove bold styling for usernames &…

447fe4e

… put comma in between

VipinDevelops requested changes Jul 21, 2025

View reviewed changes

VipinDevelops merged commit db40cc1 into RocketChat:main Jul 23, 2025
1 check passed

[FEAT]: send email & summary as email using slash command. #13

[FEAT]: send email & summary as email using slash command. #13

Uh oh!

Conversation

priyanshuharshbodhi1 commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Videos:

Uh oh!

priyanshuharshbodhi1 commented Jul 12, 2025

Uh oh!

priyanshuharshbodhi1 commented Jul 12, 2025

Uh oh!

VipinDevelops commented Jul 14, 2025

Uh oh!

VipinDevelops commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VipinDevelops Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VipinDevelops commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

priyanshuharshbodhi1 commented Jul 14, 2025

Uh oh!

VipinDevelops commented Jul 15, 2025

Uh oh!

priyanshuharshbodhi1 commented Jul 17, 2025

Uh oh!

VipinDevelops commented Jul 17, 2025

Uh oh!

priyanshuharshbodhi1 commented Jul 18, 2025

Uh oh!

priyanshuharshbodhi1 commented Jul 18, 2025

Uh oh!

priyanshuharshbodhi1 commented Jul 18, 2025

Uh oh!

VipinDevelops commented Jul 19, 2025

Uh oh!

VipinDevelops commented Jul 19, 2025

Uh oh!

VipinDevelops left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

priyanshuharshbodhi1 commented Jul 12, 2025 •

edited

Loading

VipinDevelops commented Jul 14, 2025 •

edited

Loading

VipinDevelops Jul 14, 2025 •

edited

Loading

VipinDevelops commented Jul 14, 2025 •

edited

Loading

priyanshuharshbodhi1 Jul 23, 2025 •

edited

Loading

priyanshuharshbodhi1 Jul 23, 2025 •

edited

Loading