Skip to content

Conversation

@Rochet2
Copy link
Owner

@Rochet2 Rochet2 commented Jul 22, 2025

DONE:

  • Messaging works
  • Addon sending works
  • Compression works
  • Examples work
  • Saved variables work
  • Had to change server->client message length to 255 to prevent crashes
  • sending message to multiple players in one call is now disabled, send the message to each one separately

TODO:

  • Saving position does not work yet, LibWindow is disaibled.
  • There are debug prints and comments etc that need to be cleaned up
  • The code is messy and should be cleaned up
  • Client and server files are currently different
  • Cores take in different params for the Whisper function. Need to pass in correct param based on core (guid vs player)
  • Docs need to be updated to reflect new functions and changes
  • Should test how drunkenness etc affects the messaging
  • There are a few TODO comments that need to be fixed

Classic quirks:

  • Many functions do not exist: select, match, #, print, SetSize
    • equivalent functions can be defined by hand or some alternative needs to be used like SetWidth and SetHeight.
  • Functions work differently: find, unpack, SetPoint
    • equivalent functions can be defined by hand
  • Event arguments are passed through global variables called: event, this, arg1, arg2, arg3, ....
    • we need to check if we are on vanilla client and use vanilla args instead
  • _G is not exposed, math.huge does not exist, global variables are not global and must be set with getglobal and setglobal
    • create functions and definitions for same purposes
  • strings do not have methods
    • instead one must explicitly call string.find(s) instead of s:find()
  • Addon messages cannot be sent as whisper
    • Instead use normal whisper and hide the messages from chat.
  • Long comments using [====[ syntax does not work
  • varargs do not work in the same way
    • Some workarounds are to use tables and unpack or use fixed amount of parameters (ARGS_MAX)
  • the key n in tables is reserved and should not be used.

@Rochet2 Rochet2 changed the title Initial vanilla port Vanilla port Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants