Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 make a unit test #22

Merged
merged 6 commits into from
Jun 4, 2021
Merged

4 make a unit test #22

merged 6 commits into from
Jun 4, 2021

Conversation

edelarua
Copy link
Collaborator

@edelarua edelarua commented Jun 2, 2021

@gmbecker I made a unit test for the subjid_func function to review. I'm not sure if there's a reason why the test.R file was commented out so I left it how it was.

close #22

@gmbecker
Copy link
Collaborator

gmbecker commented Jun 2, 2021

@edelarua looks like the change to devel = TRUE when calling pkgdown::build_site is causing the job to fail because the package is no longer getting installed, which building the vignettes obviously requires. Please revert that and see if you can get it passing the checks again with the rest of your changes.

It is a pretty big fail on pkgdown's part that it provides an option that will just fail like that, but 🤷

@gmbecker
Copy link
Collaborator

gmbecker commented Jun 2, 2021

@edelarua sorry I didn't see your previous comment sooner, but we do need the tests to be uncommented, they won't run (or do anything) as they are now. Please uncomment them, make sure they pass for you locally, and then update the pull request

@edelarua
Copy link
Collaborator Author

edelarua commented Jun 2, 2021

@gmbecker everything seems to be passing again after turning off developer mode in the circleci config file - thanks!

@waddella waddella mentioned this pull request Jun 4, 2021
@edelarua edelarua merged commit 73768ef into master Jun 4, 2021
@edelarua edelarua deleted the 4_make_unittest branch June 4, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants