test: [RJD-937] to Implement Unit tests on simple_sensor_simulator #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added unit tests to DetectionSensorBase - Added unit tests to LidarSensor and LidarSensorBase - Added unit tests to Primitive
- Used non trivial sensor pose in PrimitiveTest
robomic
reviewed
Jun 20, 2024
..._sensor_simulator/test/src/sensor_simulation/detection_sensor/test_detection_sensor_base.cpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/test/src/sensor_simulation/lidar/test_lidar_sensor.hpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.cpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.hpp
Show resolved
Hide resolved
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.hpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.hpp
Outdated
Show resolved
Hide resolved
simulation/simple_sensor_simulator/test/src/sensor_simulation/lidar/test_lidar_sensor.hpp
Outdated
Show resolved
Hide resolved
robomic
reviewed
Jun 20, 2024
simulation/simple_sensor_simulator/test/src/sensor_simulation/lidar/test_lidar_sensor.hpp
Outdated
Show resolved
Hide resolved
robomic
reviewed
Jun 20, 2024
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.cpp
Outdated
Show resolved
Hide resolved
robomic
reviewed
Jun 20, 2024
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.cpp
Outdated
Show resolved
Hide resolved
robomic
reviewed
Jun 20, 2024
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.cpp
Outdated
Show resolved
Hide resolved
robomic
reviewed
Jun 20, 2024
simulation/simple_sensor_simulator/test/src/sensor_simulation/primitives/test_primitive.cpp
Outdated
Show resolved
Hide resolved
- Removed DetectionSensorBase unit tests - Refactored LidarSensorTest and RaycastTest - Refactored PrimitvieTest - Added new header file with helper functions
- Added missing header file
- Refactored helper functions
- Refactored LidarSensor tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This PR contains unit tests for:
Details
Below tests are expected to fail because DetectionSensorBase do not implement the getDetectedObjects and getSensorPose function.
17. getSensorPose_noEgo
18. getSensorPose_correct
19. getDetectedObjects
References
Jira ticket: link
Destructive Changes
There are no destructive changes