-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pointcloud] New interfaces and automatic asset reloading #49
Conversation
I'm unable to fix those formatting issues like I mash reformat and nothing happens, I think my formatting style is correct as I was able to fix other issues using the same formatting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply clang-format-15
Gems/Pointcloud/Code/Source/Render/PointcloudFeatureProcessor.cpp
Outdated
Show resolved
Hide resolved
Gems/Pointcloud/Code/Source/Render/PointcloudFeatureProcessor.cpp
Outdated
Show resolved
Hide resolved
Gems/Pointcloud/Code/Source/Render/PointcloudFeatureProcessor.cpp
Outdated
Show resolved
Hide resolved
Gems/Pointcloud/Code/Source/Render/PointcloudFeatureProcessor.cpp
Outdated
Show resolved
Hide resolved
Gems/Pointcloud/Code/Source/Render/PointcloudFeatureProcessor.h
Outdated
Show resolved
Hide resolved
c7227a7
to
82d0098
Compare
I've fixed code with help of o3de Discord : https://discord.com/channels/805939474655346758/816043601754325023/1271239320698748951 untitled.webmWith permission from @Fireronin, I've forced pushed code. |
I've added @norbertprokopiuk @zakmat to review, since they are using this code. |
Co-authored-by: Krzysztof Rymski <krzysztof.rymski@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
82d0098
to
9f813e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement. Thanks! I would love to see such handling in other places where we BlockUntilCompleted
There is a small but significant bug in the component's Activate - no check for visibility.
Additionally, the m_numPoints is no longer updated.
Gems/Pointcloud/Code/Source/Tools/Components/PointcloudEditorComponent.cpp
Show resolved
Hide resolved
Gems/Pointcloud/Code/Source/Tools/Components/PointcloudEditorComponent.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Resolves #40
Adds AcquirePointcloudFromAsset and UpdatePointCloud
Interfaces to feature processor.
First one creates a ponint cloud based on asset and keeps track of it's changes.
Second one allows for partial updates to pointcloud data