Move Rolling IDL tests from Linux x64 to ARM64 - #1612
Merged
minggangw merged 2 commits intoSep 18, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Correct the ARM64 ROS tarball architecture suffix to resolve the installation failure.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Moves the Rolling ROSIDL test lane from Linux x64 to Linux ARM64.
Changes:
- Removes the Rolling IDL test leg from x64.
- Adds the equivalent ARM64 test lane and ROS setup.
- Updates ARM64 workflow conditions and dependencies.
File summaries
| File | Summary |
|---|---|
.github/workflows/linux-x64-build-and-test.yml |
Removes the x64 Rolling IDL test leg. |
.github/workflows/linux-arm64-build-and-test.yml |
Adds the ARM64 Rolling IDL test lane; the ROS tarball URL uses linux-arm64 instead of the required linux-aarch64. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| architecture: arm64 | ||
| docker_image: ubuntu:resolute | ||
| ros_distribution: rolling | ||
| ros_tar_url: "https://github.com/ros2/ros2/releases/download/release-rolling-nightlies/ros2-rolling-nightly-linux-arm64.tar.bz2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI coverage
This table describes configured coverage, not CI run results.
Regular tests include Mocha, TypeScript declarations (tsd), and Electron, subject to platform blocklists.
Total on develop remains 16 jobs: five Linux x64, five Linux ARM64, five Windows, and one ASan job.
Fix: #1591