Skip to content

Move Rolling IDL tests from Linux x64 to ARM64 - #1612

Merged
minggangw merged 2 commits into
RobotWebTools:developfrom
minggangw:move-idl-test-to-arm64
Sep 18, 2026
Merged

minggangw merged 2 commits into
RobotWebTools:developfrom
minggangw:move-idl-test-to-arm64

Conversation

@minggangw

@minggangw minggangw commented Sep 18, 2026 •

Copy link
Copy Markdown
Member
  • Move Rolling/Node 26 IDL testing from x64 to ARM64 using the Ubuntu Resolute nightly tarball.
  • Check out the repository before ROS setup to reuse the shared apt action, then install Rolling runtime dependencies with rosdep.
  • Select ARM64 Node versions per ROS release: Node 20 for Humble and Jazzy, Node 22 for Kilted, Node 24 for Lyrical, and Node 26 for Rolling.
  • Separate ARM64 IDL execution from regular tests and skip unnecessary Electron dependencies and apt interface packages for Rolling.
  • Add fail-fast handling to regular ARM64 test commands while preserving bounded retries.
  • Remove the x64 IDL matrix entry, test step, and obsolete suite conditions while retaining regular tests, lint, and coverage uploads.

CI coverage

This table describes configured coverage, not CI run results.
Regular tests include Mocha, TypeScript declarations (tsd), and Electron, subject to platform blocklists.

Platform ROS 2 releases Node Validation Jobs
Linux x64 Humble Hawksbill, Jazzy Jalisco, Kilted Kaiju, Lyrical Luth 24.X Build, regular tests, lint; Lyrical uploads coverage 4
Linux x64 Rolling Ridley 26.X Build, regular tests, lint 1
Linux ARM64 Humble Hawksbill, Jazzy Jalisco 20.X Build and regular tests 2
Linux ARM64 Kilted Kaiju 22.X Build and regular tests 1
Linux ARM64 Lyrical Luth 24.X Build and regular tests 1
Linux ARM64 Rolling Ridley 26.X Build and IDL-mode Mocha 1
Windows x64 Lyrical Luth 22.X Build and regular tests 1
Windows x64 Humble Hawksbill, Jazzy Jalisco, Kilted Kaiju, Rolling Ridley 22.X Build only 4
Linux x64 ASan Lyrical Luth 24.X Sanitized build and blocklist-filtered Mocha 1

Total on develop remains 16 jobs: five Linux x64, five Linux ARM64, five Windows, and one ASan job.

Fix: #1591

Copilot AI lite review requested due to automatic review settings September 18, 2026 05:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Correct the ARM64 ROS tarball architecture suffix to resolve the installation failure.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Moves the Rolling ROSIDL test lane from Linux x64 to Linux ARM64.

Changes:

  • Removes the Rolling IDL test leg from x64.
  • Adds the equivalent ARM64 test lane and ROS setup.
  • Updates ARM64 workflow conditions and dependencies.
File summaries
File Summary
.github/workflows/linux-x64-build-and-test.yml Removes the x64 Rolling IDL test leg.
.github/workflows/linux-arm64-build-and-test.yml Adds the ARM64 Rolling IDL test lane; the ROS tarball URL uses linux-arm64 instead of the required linux-aarch64.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

architecture: arm64
docker_image: ubuntu:resolute
ros_distribution: rolling
ros_tar_url: "https://github.com/ros2/ros2/releases/download/release-rolling-nightlies/ros2-rolling-nightly-linux-arm64.tar.bz2"
@coveralls

coveralls commented Sep 18, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 90.956% (+0.001%) from 90.955% — minggangw:move-idl-test-to-arm64 into RobotWebTools:develop

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow migration is complete and consistent with the stated CI coverage.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@minggangw
minggangw merged commit 8847f03 into RobotWebTools:develop Sep 18, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cover Node.js 22 in Windows CI

3 participants