Revise RoboSuiteLauncher to launch FaceLogin instead of RoboTutor#1
Revise RoboSuiteLauncher to launch FaceLogin instead of RoboTutor#1kapilv19 wants to merge 2 commits intodevelopmentfrom
Conversation
Integrated app pinning
JackMostow
left a comment
JackMostow
left a comment
There was a problem hiding this comment.
Please document effects of changes to min and target sdkversion.
|
add development branch to merge into instead |
JackMostow
left a comment
JackMostow
left a comment
There was a problem hiding this comment.
I'm approving these changes in the interest of moving forward, but I'd expect launching FaceLogin instead of RoboTutor to require changing only 2 lines -- one to change the name of the app to be launched, and one to change the version number of RoboSuiteLauncher, plus possibly a line or two to pin apps -- not 83 files! I gather that the 83 files are copied from the RoboTutor_2020 repo rather than imported from it. Can you revise the commit to do it that way instead? If not, please explain why. Copying code is dangerous because it creates the risk of updating one copy but not another.
JackMostow
left a comment
JackMostow
left a comment
There was a problem hiding this comment.
OK AFAIK, but I wouldn't spot problems
2 participants
Revised RoboSuiteLauncher to launch FaceLogin instead of RoboTutor, added app pinning, util module, logging module, and config module.