Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turtle #142

Merged
merged 7 commits into from
Mar 5, 2023
Merged

Turtle #142

merged 7 commits into from
Mar 5, 2023

Conversation

ldania
Copy link
Contributor

@ldania ldania commented Nov 28, 2022

System changes to allow Turtle Sim in Jupyros2

@IsabelParedes
Copy link
Collaborator

Hi @ldania!
thanks for you PR. Before we can merge, though, we'll have to do a bit of cleanup. It looks like you commit history is much longer than it should be. To me only the last 6 commits seem relevant for this PR (from cbbafea).
Also, taking a quick look at the notebooks, only the two turtle notebooks should be part of this PR and the others shouldn't have changes. But if the other notebooks do need changes, that should be part of a separate PR. And for consistency, don't forget to clear the notebook outputs.
I'll do a more detailed review once you make these changes.

Thanks :)

@ldania
Copy link
Contributor Author

ldania commented Dec 8, 2022

Hi Isabel,

The PRs have been fixed and should be ready for approval.
The Publisher and Keyboard control notebooks are the same as the latest PR change (small changes PR).

@ldania
Copy link
Contributor Author

ldania commented Feb 15, 2023

Sorry for the downtime, but If im correct the current PR should be implementable, kindly an update?

@IsabelParedes
Copy link
Collaborator

Hi @ldania,
Apologies for the late feedback. Looks like your PR is working great, it should be implementable. The only suggestion I have (but it's not necessary) would be to move the keyboard control to be part of the jupyros package itself. And then the scaling could be turned into a speed widget for example. Other than that, it looks good!

@IsabelParedes IsabelParedes added the enhancement New feature or request label Feb 16, 2023
@hbcarlos
Copy link
Member

hbcarlos commented Mar 5, 2023

Thanks!!

@hbcarlos hbcarlos merged commit b7ca8d7 into RoboStack:main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants