Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 keyboard fixed #134

Merged
merged 12 commits into from
Nov 2, 2022
Merged

Conversation

ldania
Copy link
Contributor

@ldania ldania commented Oct 19, 2022

Due to many merged conflicts concerning the previous pull request, A rebase was needed, which was easier with another branch

@IsabelParedes IsabelParedes added the enhancement New feature or request label Nov 2, 2022
@wolfv
Copy link
Member

wolfv commented Nov 2, 2022

@ldania just FYI your git is wrongly configured. The email is ldania@github.com.

You can change it with git config --global user.email ... I think.

that is why the commits do not show your avatar and are not associated with your account.

@IsabelParedes IsabelParedes self-requested a review November 2, 2022 10:14
Copy link
Collaborator

@IsabelParedes IsabelParedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@IsabelParedes IsabelParedes merged commit 0fde91b into RoboStack:master Nov 2, 2022
@IsabelParedes IsabelParedes mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants