Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow $0 trip fees #4499

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Allow $0 trip fees #4499

merged 5 commits into from
Mar 21, 2024

Conversation

kberzinch
Copy link
Member

@kberzinch kberzinch commented Mar 21, 2024 •
edited
Loading

Mailbook link: https://apiary-test.robojackets.org/mailbook?selected=App%5CNotifications%5CTravel%5CTravelAssignmentCreated&variant=need-travel-information-form-no-payment&locale=en

Deferred changes:

  • Assignment completion email sent to primary contact and treasurer
  • Hide payment information on trip assignment detail
  • Travel assignment creation email uses plural "tasks" for just form

@kberzinch kberzinch self-assigned this Mar 21, 2024
@kberzinch kberzinch marked this pull request as ready for review March 21, 2024 00:50
@kberzinch kberzinch merged commit eadffc9 into main Mar 21, 2024
9 checks passed
@kberzinch kberzinch deleted the kristaps/free-trips branch March 21, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshOldenburg JoshOldenburg JoshOldenburg approved these changes

@RossIV RossIV Awaiting requested review from RossIV

@evan10s evan10s Awaiting requested review from evan10s

Assignees

@kberzinch kberzinch

Labels
area / backend priority / critical type / feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kberzinch @JoshOldenburg