Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralized whitelist #4

Open
LPGhatguy opened this issue Jun 12, 2020 · 2 comments · May be fixed by #16
Open

Centralized whitelist #4

LPGhatguy opened this issue Jun 12, 2020 · 2 comments · May be fixed by #16
Labels
enhancement New feature or request

Comments

@LPGhatguy
Copy link

It requires some duplicated effort to maintain an employee whitelist across many repositories in the same organization.

It would be great to support pulling the contributor whitelist from a central repository, perhaps the same repository that contains who has signed the CLA.

@LPGhatguy LPGhatguy added the enhancement New feature or request label Jun 12, 2020
@cliffchapmanrbx
Copy link
Contributor

Yep this would be a great feature to add. The primary way we were talking about implementing this was as a check against membership in the organization that owns the repository. I'm not sure if the provided GITHUB_TOKEN has the scope necessary to hit the organization API to request membership details so it might depend on #3 and properly implementing a GitHub App for auth instead of using a PAT.

@cliffchapmanrbx
Copy link
Contributor

It is super unclear if this can be done using the GITHUB_TOKEN that comes out of the box. According to the permission list the metadata endpoint is available which can read the list of members in the org. However the info for the list members endpoint indicates the requestor must be a member of the org to get non-public information. So if the requestor is the github action does that count?

No idea. Gotta test.

Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
The new `allowOrganizationMembers` flag will automatically allow all
users in the same organization as the repository. It will be as though
all organization members are on the `whitelist`.

If this is enabled for a repository not in an organization, an error
will be thrown.

This input parameter defaults to `false`. Tests and documentation have
been updated.

Fixes Roblox#4
@Gudahtt Gudahtt linked a pull request Aug 26, 2020 that will close this issue
Gudahtt referenced this issue in MetaMask/cla-signature-bot Aug 26, 2020
The new `allowOrganizationMembers` flag will automatically allow all
users in the same organization as the repository. It will be as though
all organization members are on the `whitelist`.

If this is enabled for a repository not in an organization, an error
will be thrown.

This input parameter defaults to `false`. Tests and documentation have
been updated.

Fixes #4
Gudahtt added a commit to Gudahtt/cla-signature-bot that referenced this issue Aug 26, 2020
The new `allowOrganizationMembers` flag will automatically allow all
users in the same organization as the repository. It will be as though
all organization members are on the `whitelist`.

If this is enabled for a repository not in an organization, an error
will be thrown.

This input parameter defaults to `false`. Tests and documentation have
been updated.

Fixes Roblox#4
Gudahtt referenced this issue in MetaMask/cla-signature-bot Aug 26, 2020
The new `allowOrganizationMembers` flag will automatically allow all
users in the same organization as the repository. It will be as though
all organization members are on the `whitelist`.

If this is enabled for a repository not in an organization, an error
will be thrown.

This input parameter defaults to `false`. Tests and documentation have
been updated.

Fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants