Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10 is for Gisberta Salce Júnior #864

Merged
merged 50 commits into from
Mar 20, 2023
Merged

v10 is for Gisberta Salce Júnior #864

merged 50 commits into from
Mar 20, 2023

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Mar 8, 2023 •
edited
Loading

image

Gisberta Salce Júnior was a trans woman, a Brazilian immigrant who did sex work, lived with HIV/AIDS and was homeless in the city of Porto in Portugal. She left Brazil for France at the age of 18 to escape a wave of hate crime homicides against transgender people in São Paulo and, at the age of 20, arrived in Portugal. In 2006, after several days of physical and sexual assaults motivated by transphobia and perpetrated by a group of 14 boys between 12 and 16 years old, she was found dead in a well, in Porto, at the age of 45

https://resistadotblog.wordpress.com/2018/02/22/uma-sentenca-de-morte-para-gisberta/

Here is what included

@RobinTail RobinTail added the breaking Backward incompatible changes label Mar 8, 2023
@RobinTail RobinTail added this to the v10 milestone Mar 8, 2023
RobinTail
RobinTail commented Mar 8, 2023
View reviewed changes
src/index.ts
import * as z from "./extend-zod";
import createHttpError from "http-errors";
export { z } from "zod";
export { ez } from "./ez-namespace";
Copy link
Owner Author

@RobinTail RobinTail Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking: the proprietary schemas are in ez now

@RobinTail RobinTail mentioned this pull request Mar 8, 2023
Merged
@RobinTail
Stop re-exporting zod (#865)
92da319 
* Stop reexporting zod.

* Temp enabling the workflows.

* Moving zod to dev and peers.

* Add zod into ESM and intergration package generator.

* Readme: adjusting the quick start which is used for integration test generator.
RobinTail
RobinTail commented Mar 8, 2023
View reviewed changes
package.json
},
"peerDependencies": {
"@types/jest": "*",
"jest": ">=25 <30",
"typescript": "^4.1"
"typescript": "^4.1",
"zod": "^3.21.4"
Copy link
Owner Author

@RobinTail RobinTail Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking: zod becomes a peer dependency

@RobinTail RobinTail linked an issue Mar 8, 2023 that may be closed by this pull request
Locking package versions #822
Closed
@RobinTail RobinTail added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Mar 8, 2023
@RobinTail
Making express a peer (#866)
965c536 
* Making express to be a peer and dev dependency.

* Making @types/express an optional peer.
RobinTail
RobinTail commented Mar 8, 2023
View reviewed changes
package.json
"@types/jest": "*",
"express": "^4.18.2",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking: express becomes a peer dependency

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/express is an optional peer

RobinTail
RobinTail commented Mar 8, 2023
View reviewed changes
package.json
"express-fileupload": "1.4.0",
"http-errors": "2.0.0",
"mime": "3.0.0",
"openapi3-ts": "3.2.0",
"ramda": "0.28.0",
"triple-beam": "1.3.0",
"typescript": "4.9.5",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking: typescript becomes an optional peer, needed for the client generating only

RobinTail added 2 commits March 8, 2023 22:18
@RobinTail
Ref: listing the new dev dependencies more loose.
23d43b6
@RobinTail
Switching to tsup (#584)
8e87583 
* Installing tsup and including the sample configuration.

* Changing the build approach.

* Changing paths in package.json.

* Changing path to the ESM package in the ESM package generator.

* Removing the deleted folder from ignores.

* Moving the ESM package tool to onSuccess of the tsup config.

* Using minify.

* Preserving DTS split by tsc.

* Fix int and esm tests.

* Min Node version 14.18.0.

* Upgrading tsup.

* No need for the cleanup command.

* Using the DTS generator of TSUP (finally).

* Validate types in test command.

* Shorten commands.

* More advanced esm test preparation and details.

* Revert "More advanced esm test preparation and details."

This reverts commit 32c6539.
RobinTail
RobinTail commented Mar 8, 2023
View reviewed changes
package.json
},
"engines": {
"node": "^14.17.0 || ^16.10.0 || ^18.0.0 || ^19.0.0"
"node": "^14.18.0 || ^16.10.0 || ^18.0.0 || ^19.0.0"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking, min Node version for 14th

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, 14th is about to be EOL in April...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'll keep it as the LTS as long and possible

RobinTail
RobinTail commented Mar 8, 2023
View reviewed changes
package.json
"jest": ">=25 <30",
"typescript": "^4.1"
"typescript": "^4.9.3",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Min version of typescript (optional peer) is 4.9.3

@RobinTail RobinTail added the CI/CD label Mar 8, 2023
@RobinTail
Copy link
Owner Author

RobinTail commented Mar 9, 2023 •
edited
Loading

🚀 Released 10.0.0-beta1

There is a couple issues with the types declaration made by tsup.

First one

TS4023: Exported variable '' has or is using name 'BasicSecurity' from external module "/node_modules/express-zod-api/dist/index" but cannot be named.

Second

TS4094: Property 'descriptions' of exported class expression may not be private or protected.

@RobinTail
Copy link
Owner Author

both errors caused by "insufficient exports".
for some reason it wants to have a direct access to certain non-exported entities.
Investigating.

@RobinTail
Copy link
Owner Author

Fixed by removing redundant declaration: true options in tsconfig.json
microsoft/TypeScript#5711 (comment)

@RobinTail RobinTail mentioned this pull request Mar 9, 2023
Merged
@RobinTail
Copy link
Owner Author

RobinTail commented Mar 9, 2023 •
edited
Loading

✅ Tested on a real deployment — operational.

@RobinTail
Switching to SWC 🐎 (#877)
0e8e851 
* Using SWC for tests.

* Fixing express mocking.

* Easier express mock.

* Removing redundant beforeEach and export of mocker.

* Easier mock (2).

* Removing ts-jest.

* Enabling SWC for ts-node.

* Minor adjustments.

* Fix unused export.

* Exclude index.ts from coverage evaluation.

* Fixed another unused export.

* Testing the exports of index entrypoint.

* ESLint: allow all imports in tests.

* Ref: better implementation for index test.
@RobinTail RobinTail added coverage Additional tests refactoring The better way to achieve the same result labels Mar 12, 2023
@RobinTail RobinTail linked an issue Mar 12, 2023 that may be closed by this pull request
OpenAPI spec generates extra examples if the output schema extends the input schema #827
Closed
@RobinTail
Copy link
Owner Author

RobinTail commented Mar 14, 2023 •
edited
Loading

Something is broken in Node 19.8 for tsup

@RobinTail
Copy link
Owner Author

🚀 v10.0.0-beta5 released

@RobinTail
Copy link
Owner Author

The 19.8 Node's bug was fixed. New version should come shortly.
nodejs/node#47096

@RobinTail
Revert "Test on 19.7."
b77a9b7 
This reverts commit 0a2b228.
@RobinTail
Copy link
Owner Author

The issue reported to be fixed, but the release package 19.8.1 is still having some troubles.

@RobinTail
Copy link
Owner Author

Ok. Now it's another issue — of actions/setup-node this time
actions/setup-node#714

@RobinTail
Copy link
Owner Author

Generally ready

RobinTail
RobinTail commented Mar 20, 2023
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@RobinTail RobinTail merged commit 1a4303c into master Mar 20, 2023
@RobinTail RobinTail deleted the v10-beta branch March 20, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Backward incompatible changes CI/CD coverage Additional tests dedication dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation prevention refactoring The better way to achieve the same result
Projects
None yet
Milestone
v10
Development

Successfully merging this pull request may close these issues.

OpenAPI spec generates extra examples if the output schema extends the input schema Locking package versions
1 participant
@RobinTail