Skip to content

UnbindKeyCombo does not work without providing a handler #62

@thiemok

Description

@thiemok

Describe the bug
UnbindKeyCombo does not remove bindings properly when no handler is provided to the call.
I believe this might be happening because keyComboStatesArray is not updated here

To Reproduce
Steps to reproduce the behavior:

  1. Pick a shortcut
  2. Call bindKeyCombo(shortcut, () => console.log('a'))
  3. Call unbindKeyCombo(shortcut)
  4. Call bindKeyCombo(shortcut, () => console.log('b'))
  5. Trigger shortcut

Expected behavior
Console logs only "b"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions