feat(release): Multi-edition release workflow v6.0.2 #77
Conversation
Update release workflow to build, sign, and notarize all 4 editions: - Master: Full-featured for power users (convergio) - Education: Schools and students (convergio-edu) - Business: Enterprise features (convergio-biz) - Developer: Debug tools and APIs (convergio-dev) Changes: - release.yml: Build all editions in parallel - release.yml: Sign and notarize all binaries - release.yml: Create separate tarballs with SHA256 checksums - release.yml: Generate release notes with download table - VERSION: Bump to 6.0.2 - CHANGELOG.md: Add v6.0.2 entry - README.md: Update download links to v6.0.2 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR implements a multi-edition release workflow for Convergio CLI v6.0.2, enabling the automated build, signing, and distribution of four distinct product editions through GitHub releases.
Key Changes:
- Enhanced GitHub Actions release workflow to build all 4 editions (Master, Education, Business, Developer) with separate signed and notarized binaries
- Updated version from 6.0.1 to 6.0.2 across all documentation and release artifacts
- Fixed VERSION file formatting by removing leading whitespace
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| VERSION | Bumped version to 6.0.2 and fixed formatting by removing leading whitespace |
| README.md | Updated version badges and download links to reference v6.0.2 for all four editions |
| CHANGELOG.md | Added v6.0.2 release entry documenting the multi-edition release feature |
| .github/workflows/release.yml | Comprehensive workflow update to build, sign, notarize, and release all 4 editions as separate tarballs with individual SHA256 checksums |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Master edition (includes ConvergioNotify.app if available) | ||
| cd dist/master | ||
| if [ -d ConvergioNotify.app ]; then | ||
| tar -czvf ../../dist/convergio-${{ steps.version.outputs.VERSION }}-arm64-apple-darwin.tar.gz convergio ConvergioNotify.app | ||
| tar -czvf ../convergio-${VERSION}-arm64-apple-darwin.tar.gz convergio ConvergioNotify.app | ||
| else | ||
| tar -czvf ../../dist/convergio-${{ steps.version.outputs.VERSION }}-arm64-apple-darwin.tar.gz convergio | ||
| tar -czvf ../convergio-${VERSION}-arm64-apple-darwin.tar.gz convergio | ||
| fi | ||
| cd ../.. | ||
|
|
||
| - name: Calculate SHA256 | ||
| # Education edition | ||
| cd dist/education | ||
| tar -czvf ../convergio-edu-${VERSION}-arm64-apple-darwin.tar.gz convergio-edu | ||
| cd ../.. | ||
|
|
||
| # Business edition | ||
| cd dist/business | ||
| tar -czvf ../convergio-biz-${VERSION}-arm64-apple-darwin.tar.gz convergio-biz | ||
| cd ../.. | ||
|
|
||
| # Developer edition | ||
| cd dist/developer | ||
| tar -czvf ../convergio-dev-${VERSION}-arm64-apple-darwin.tar.gz convergio-dev | ||
| cd ../.. |
There was a problem hiding this comment.
The tarball creation logic changes directories multiple times without proper error handling. If any 'cd' command fails, subsequent commands could create tarballs in unexpected locations. Consider using absolute paths or adding error checking with 'cd ... || exit 1' to ensure commands fail fast if directory navigation fails.
| # Create combined ZIP with all binaries for notarization | ||
| cd dist | ||
| zip -r all-editions.zip master/ education/ business/ developer/ | ||
| cd .. | ||
|
|
||
| - name: Notarize binary | ||
| - name: Notarize binaries | ||
| env: | ||
| APPLE_ID: ${{ secrets.APPLE_ID }} | ||
| APPLE_APP_PASSWORD: ${{ secrets.APPLE_APP_PASSWORD }} | ||
| APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }} | ||
| run: | | ||
| xcrun notarytool submit build/bin/convergio.zip \ | ||
| xcrun notarytool submit dist/all-editions.zip \ | ||
| --apple-id "$APPLE_ID" \ | ||
| --password "$APPLE_APP_PASSWORD" \ | ||
| --team-id "$APPLE_TEAM_ID" \ | ||
| --wait |
There was a problem hiding this comment.
Notarizing all editions in a single ZIP file may cause issues. Apple's notarization service typically expects a single app bundle or a flat package. While this might work, if notarization fails, consider notarizing each edition separately using individual ZIP files, especially since each edition is distributed as a separate tarball. This would also provide more granular control and clearer error messages if notarization fails for a specific edition.
Summary
Editions
convergioconvergio-educonvergio-bizconvergio-devChanges
.github/workflows/release.yml: Build all 4 editionsVERSION: 6.0.2CHANGELOG.md: v6.0.2 entryREADME.md: Updated download linksTest plan
After merge, tag with
v6.0.2to trigger the release workflow.🤖 Generated with Claude Code