Logic and performance fix (Fraction lib). #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilized initializer lists rather than assigning.
Changed by-value elements to by-reference. Also changed private section to protected; in case someone wants to inherit the Fraction class.
Chris--A
changed the title
RobTillaart
added a commit
that referenced
this pull request
Mar 5, 2015
Logic and performance fix (Fraction lib). LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows a standard use of operators defined in the class.
Some function parameters and return values have been modified.
No more private section, just protected. This allows people to provide derivatives or updates easily.