Skip to content

handle curl errors. fix #129#130

Merged
NicolasCARPi merged 2 commits intomasterfrom
nico-curlerr
May 7, 2024
Merged

handle curl errors. fix #129#130
NicolasCARPi merged 2 commits intomasterfrom
nico-curlerr

Conversation

@NicolasCARPi
Copy link
Collaborator

if curl fails for some reason to get a QR code from an external (http) provider, the app will throw a TwoFactorAuthException.

also fix the demo page with new constructor signature

if curl fails for some reason to get a QR code from an external (http)
provider, the app will throw a TwoFactorAuthException.

also fix the demo page with new constructor signature
and change the function signature
Copy link
Collaborator

@willpower232 willpower232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@RobThree
Copy link
Owner

RobThree commented May 7, 2024

noice

What he said

@NicolasCARPi NicolasCARPi merged commit df43660 into master May 7, 2024
@NicolasCARPi NicolasCARPi deleted the nico-curlerr branch May 7, 2024 12:14
NicolasCARPi added a commit that referenced this pull request May 12, 2024
NicolasCARPi added a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants