make QR Code Provider a mandatory constructor argument#125
make QR Code Provider a mandatory constructor argument#125NicolasCARPi merged 5 commits intoRobThree:masterfrom NicolasCARPi:nico-qr
Conversation
|
Nice. I so wish I had the time to implement a 'self contained' QR code provider with SVG or PNG. Maybe, someday... |
|
@RobThree BTW, would you be so kind as to allow my account write access to this repo? My main argument is that it would save me from having to maintain a fork, but it can also be helpful if I can close issues and review other PRs. It will also help users identify this account as a contributor. I promise I'm not playing long term game for planting a backdoor ^^ |
|
I have no issue with that, but just to keep playing nice I'll have a quick glance at @willpower232 (which, I'm sure, will agree).
Hah, well guess what buddy, now the answer is no! 🤣 Who's laughing now? |
|
No issues with having another person with write access, as long as all the drastic stuff goes through PR or with @RobThree 's public consent, its all cool |
In fact I'd go as far as locking down the |
willpower232
left a comment
willpower232
left a comment
There was a problem hiding this comment.
I'm clicking approve but probably should update the changelog as this counts as another breaking change
Of course, but I prefer to leave it out of commits, and do a dedicated CHANGELOG commit once we have everything we want (which I believe is the case for the next release). |
3 participants
This change is discussed in #104
Currently, the library defaults to a QR Code Provider using an external service, thus leaking secrets.
This change forces the definition of a QR Code Provider in the constructor. It is a breaking change.
fixes #104
The public function
getQRCodeProvider()has been removed. It is provided by the user in the constructor, so it doesn't make a lot of sense to keep a getter around if we're not using it internally.