remove insecure rng providers#122
remove insecure rng providers#122willpower232 merged 9 commits intoRobThree:masterfrom NicolasCARPi:nico-slim
Conversation
and remove the openssl provider. We now rely exclusively on random_bytes(), as there are no reasons not to. Fix #121
we were testing a test class, which didn't make a lot of sense.
|
I cleaned up the tests, too. The |
This reverts commit f6da6be.
|
Maybe the last commit was a bit too hasteful. Reverted for now. |
|
Isn't (or wasn't) it used to test if the 2FA class checked correctly for the |
|
Yeah, looking at it again, and given that |
|
I think it's safe to throw it out, since the |
This reverts commit 06220d4.
|
Done. |
| * Create a new secret | ||
| */ | ||
| public function createSecret(int $bits = 80, bool $requirecryptosecure = true): string | ||
| public function createSecret(int $bits = 80): string |
There was a problem hiding this comment.
mental note to document in the changelog
* master: Exclude useless files from dist archive #103
RobThree
left a comment
RobThree
left a comment
There was a problem hiding this comment.
Ignore my previous comment. LGTM.
* master: delete files specific to code editors (#120)
this also aligns with other providers
3 participants
and remove the openssl provider. We now rely exclusively on random_bytes(), as there are no reasons not to. Fix #121