Compute translation stats during build #1
+116
−229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an example of how we might avoid needing to version translation stats (and have them be potentially incorrect, require an extra stage to update, etc.)
all this does is
sys.path
)_static/translation_stats.json
it's totally fast enough to calculate the translation stats on demand - it takes about 100ms on my machine, so even though this implementation does it twice (once when drawing the graph, and once to save to json at the end of the build) it's fine.
i kept the json output in case we wanted to make that programmatically available from the site for any reason, but put the i/o in a separate function from the computation :)