Skip to content

use single build for mac #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,5 +213,5 @@ jobs:
with:
upload_url: ${{ needs.create_release.outputs.upload_url }}
asset_path: ./build/Release/node-raylib.node
asset_name: node-raylib-darwin-x64.node
asset_content_type: application/octet-stream
asset_name: node-raylib-darwin.node
asset_content_type: application/octet-stream
3 changes: 3 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ endif()

set(CMAKE_CXX_FLAGS_DEBUG "-g")

# single build for both Mac arches
set(CMAKE_OSX_ARCHITECTURES arm64 x86_64)

# version doesn't seem to pick correct version
#find_package(raylib 5.5 QUIET EXACT)
if (NOT raylib_FOUND)
Expand Down
7 changes: 6 additions & 1 deletion tools/postinstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ async function main() {

let url = `https://github.com/RobLoach/node-raylib/releases/download/v${version}/node-raylib-${process.platform}-${process.arch}.node`;

console.log(`Checking for ${url}`);
// we use a single build for both platforms on Mac
if (process.platform === 'darwin') {
url = `https://github.com/RobLoach/node-raylib/releases/download/v${process.env.npm_package_version}/node-raylib-darwin.node`
}

console.log(`Checking for ${url}`)

try {
await fs.mkdir(path.join(__dirname, "..", "build"));
Expand Down
Loading