Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for composer plugin BC break #52

Merged
merged 2 commits into from
Sep 8, 2013
Merged

Fix for composer plugin BC break #52

merged 2 commits into from
Sep 8, 2013

Conversation

hjr3
Copy link
Contributor

@hjr3 hjr3 commented Sep 6, 2013

  • New composer plugin support breaks backwards compatibility for plugins of
    type 'composer-installer'.

Fixes #51

- New composer plugin support breaks backwards compatibility for plugins of
  type 'composer-installer'.
@till
Copy link

till commented Sep 6, 2013

Just fyi — this will fail with older versions of composer.

It will look for this package and complain that it cannot find it. Maybe document that in the README because it'll be a WTF moment for many. ;)

@renanbr
Copy link

renanbr commented Sep 6, 2013

It's a really WTF moment... for a good reason :-)
maybe it's also a good moment to rename the project #37

@hjr3
Copy link
Contributor Author

hjr3 commented Sep 6, 2013

they can pin an older version in composer though. I can update the README and let people know to pin to 308220f to make it work with older versions.

@till
Copy link

till commented Sep 7, 2013

@hjr3 Yeah, that's a good idea.

@hjr3
Copy link
Contributor Author

hjr3 commented Sep 7, 2013

I added a note to the README for people using older versions of composer to pin to version 0.0.12. @RobLoach can you take a look?

@RobLoach
Copy link
Owner

RobLoach commented Sep 8, 2013

Very nice! Thanks a lot for the help, everyone. It would be great to push Composer Plugin API forwards. Do we have an issue open for that already?

RobLoach added a commit that referenced this pull request Sep 8, 2013
Fix for Composer Plugin backwards compatibility
@RobLoach RobLoach merged commit c2e456e into RobLoach:master Sep 8, 2013
@hjr3
Copy link
Contributor Author

hjr3 commented Sep 8, 2013

We may want to actually revert this commit, now that composer fixed the BC break: composer/composer@689e305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer Autoload
4 participants