Merge pull request nationalparkservice#148 from RobLBaker/main

Fix test_license so that it works properly with restricted references
RobLBaker · Sep 26, 2024 · 8a23fda · 8a23fda
2 parents a31ac96 + 3f1175c
commit 8a23fda
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/R/required_eml_elements.R b/R/required_eml_elements.R
@@ -465,7 +465,7 @@ test_cui_dissemination <- function(metadata = load_metadata(directory)) {
 #' }
 test_license <- function(metadata = load_metadata(directory)) {
   is_eml(metadata)
-  license_list <- c("Public Domain", "CC0 1.0 Universal", "No License/Controlled Unclassified Information")
+  license_list <- c("Public Domain", "CC0 1.0 Universal", "Unlicensed (not for public dissemination)")
 
   license <- metadata$dataset$licensed$licenseName
   if(is.null(license)){

diff --git a/tests/testthat/test-optional_data_checks.R b/tests/testthat/test-optional_data_checks.R
@@ -0,0 +1,17 @@
+good_dir <- test_path("good")
+bad_dir <- test_path("bad")
+bicy_meta <- load_metadata(test_path("good", "BICY_good"))
+buis_meta <- load_metadata(test_path("good", "BUIS_good"))
+
+# ---- test_pii_meta_emails
+
+test_that("test_pii_data_emails finds true negatives",
+          {
+            msg <- "Data files do not appear to contain any personal emails."
+            expect_message(test_pii_data_emails(here::here(good_dir,
+                                                           "BICY_good")),
+                           msg)
+          }
+)
+
+# ----