Skip to content

Add doctrine/annotations:v2, doctrine/event-manager:v2 and doctrine/persistence:v3 support #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

Slamdunk
Copy link
Collaborator

@Slamdunk Slamdunk commented Jan 18, 2023

I've seen that #82 and #83 have been marked as BC BREAK This PR contains a BC break; major version should be incremented but it seems to me that this can be released in a new MINOR, so we can ease the upgrade path for users.

After that, doctrine/cache:v2 needs the work of @mrVrAlex in #72 and a new MAJOR

@mrVrAlex
Copy link
Contributor

Good point.
But anyway I still have a general questions:
If we now have support ORM only from 2.14 version, where have both support for cache 1.13 || 2.0 like and both persistanse major versions, also ORM not required annotations package anymore (optional), then why these packages are locked here?)

@Slamdunk
Copy link
Collaborator Author

then why these packages are locked here?

Because we can only clean them up in a new MAJOR, while this PR is only intended for a new MINOR.

In your PR I would definitively throw out of the window any non-latest release 👍

@Ocramius Ocramius added this to the 4.0.0 milestone Jan 30, 2023
@Ocramius Ocramius added enhancement New feature or request BC BREAK This PR contains a BC break; major version should be incremented labels Jan 30, 2023
@Ocramius
Copy link
Member

@Slamdunk if this doesn't change any inherited symbols, I'd be inclined to doing it in a minor release: WDYT?

@Slamdunk
Copy link
Collaborator Author

Yes please.

@Ocramius Ocramius modified the milestones: 4.0.0, 3.9.0 Jan 31, 2023
@Ocramius Ocramius removed the BC BREAK This PR contains a BC break; major version should be incremented label Jan 31, 2023
@Ocramius Ocramius self-assigned this Jan 31, 2023
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Slamdunk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support doctrine/persistence 3.0 with ORM 2.12
3 participants