Create CompareApi interface #54
Conversation
src/ClassComparator.php
Outdated
| use function array_map; | ||
| use function sprintf; | ||
|
|
||
| class ClassComparator implements Comparator |
src/Comparator.php
Outdated
|
|
||
| class Comparator | ||
| interface Comparator |
There was a problem hiding this comment.
I think this should be named ApiComparator or such.
There was a problem hiding this comment.
Since there's only a single method, what do you think of using __invoke and naming this CompareApi or such?
There was a problem hiding this comment.
Done, I think it follows the rest of the classes nicely. What do you think about CompareClass naming? I'm not sure about it
src/Comparator.php
Outdated
| $this->interfaceBasedComparisons = $interfaceBasedComparisons; | ||
| $this->traitBasedComparisons = $traitBasedComparisons; | ||
| } | ||
|
|
||
| /** | ||
| * @param ClassReflector $definedSymbols containing only defined symbols in the compared API |
There was a problem hiding this comment.
I think I messed up the description here. The idea is that $definedSymbols is the subset of symbols we want to check
There was a problem hiding this comment.
The $newSourcesWithDependencies is also wrong - my C&P mistake, sorry :-\
ntzm
force-pushed
the
comparator-interface
branch
from
ab6b62d to
3cd9449
Compare
ntzm
force-pushed
the
comparator-interface
branch
from
3cd9449 to
0d61716
Compare
| @@ -67,7 +67,7 @@ function (string $installationPath) use ($composerIo) : Installer { | |||
| }, | |||
| $astLocator | |||
| ), | |||
| new Comparator( | |||
| new CompareClass( | |||
There was a problem hiding this comment.
Probably want to use CompareClasses, since the API works with multiple classes (plural)
ntzm
force-pushed
the
comparator-interface
branch
from
0d61716 to
daa10be
Compare
Closes #28