#24 renamed Changes::fromArray() in favour of Changes::fromList()…

…, which is type-safe

src/Changes.php

@@ -25,15 +25,12 @@ public static function empty() : self
         return new self();
     }
 
-    /**
-     * @param Change[] $changes
-     * @return Changes
-     */
-    public static function fromArray(array $changes) : self
+    public static function fromList(Change ...$changes) : self
     {
-        Assert::that($changes)->all()->isInstanceOf(Change::class);
-        $instance          = self::empty();
+        $instance = new self();
+
         $instance->changes = $changes;
+
         return $instance;
     }
 

src/Comparator.php

@@ -70,9 +70,9 @@ private function examineSymbol(
             /** @var ReflectionClass $newClass */
             $newClass = $newSourcesWithDependencies->reflect($oldSymbol->getName());
         } catch (IdentifierNotFound $exception) {
-            return $changelog->mergeWith(Changes::fromArray([
+            return $changelog->mergeWith(Changes::fromList(
                 Change::removed(sprintf('Class %s has been deleted', $oldSymbol->getName()), true)
-            ]));
+            ));
         }
 
         if ($oldSymbol->isInterface()) {

src/DetectChanges/BCBreak/ClassBased/ClassBecameAbstract.php

@@ -27,10 +27,9 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             return Changes::empty();
         }
 
-        return Changes::fromArray([Change::changed(
+        return Changes::fromList(Change::changed(
             sprintf('Class %s became abstract', $fromClass->getName()),
             true
-        ),
-        ]);
+        ));
     }
 }

src/DetectChanges/BCBreak/ClassBased/ClassBecameFinal.php

@@ -21,10 +21,9 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             return Changes::empty();
         }
 
-        return Changes::fromArray([Change::changed(
+        return Changes::fromList(Change::changed(
             sprintf('Class %s became final', $fromClass->getName()),
             true
-        ),
-        ]);
+        ));
     }
 }

src/DetectChanges/BCBreak/ClassBased/ClassBecameInterface.php

@@ -23,10 +23,9 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             return Changes::empty();
         }
 
-        return Changes::fromArray([Change::changed(
+        return Changes::fromList(Change::changed(
             sprintf('Class %s became an interface', $fromClass->getName()),
             true
-        ),
-        ]);
+        ));
     }
 }

src/DetectChanges/BCBreak/ClassBased/ClassBecameTrait.php

@@ -22,10 +22,9 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             return Changes::empty();
         }
 
-        return Changes::fromArray([Change::changed(
+        return Changes::fromList(Change::changed(
             sprintf('Class %s became a trait', $fromClass->getName()),
             true
-        ),
-        ]);
+        ));
     }
 }

src/DetectChanges/BCBreak/ClassBased/ConstantRemoved.php

@@ -23,7 +23,7 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             $this->accessibleConstants($toClass)
         );
 
-        return Changes::fromArray(array_values(array_map(function (ReflectionClassConstant $constant) use ($fromClass) : Change {
+        return Changes::fromList(...array_values(array_map(function (ReflectionClassConstant $constant) use ($fromClass) : Change {
             return Change::removed(
                 sprintf('Constant %s::%s was removed', $fromClass->getName(), $constant->getName()),
                 true

src/DetectChanges/BCBreak/ClassBased/MethodRemoved.php

@@ -35,7 +35,7 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             array_change_key_case($this->accessibleMethods($toClass), CASE_UPPER)
         );
 
-        return Changes::fromArray(array_values(array_map(function (ReflectionMethod $method) : Change {
+        return Changes::fromList(...array_values(array_map(function (ReflectionMethod $method) : Change {
             return Change::removed(
                 sprintf('Method %s was removed', $this->formatFunction->__invoke($method)),
                 true

src/DetectChanges/BCBreak/ClassBased/PropertyRemoved.php

@@ -34,7 +34,7 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             array_keys($this->accessibleProperties($toClass))
         );
 
-        return Changes::fromArray(array_values(array_map(function (string $property) use ($fromProperties) : Change {
+        return Changes::fromList(...array_values(array_map(function (string $property) use ($fromProperties) : Change {
             return Change::removed(
                 sprintf('Property %s was removed', $this->formatProperty->__invoke($fromProperties[$property])),
                 true

src/DetectChanges/BCBreak/ClassConstantBased/ClassConstantValueChanged.php

@@ -25,17 +25,15 @@ public function __invoke(ReflectionClassConstant $fromConstant, ReflectionClassC
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'Value of constant %s::%s changed from %s to %s',
-                    $fromConstant->getDeclaringClass()->getName(),
-                    $fromConstant->getName(),
-                    var_export($fromValue, true),
-                    var_export($toValue, true)
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'Value of constant %s::%s changed from %s to %s',
+                $fromConstant->getDeclaringClass()->getName(),
+                $fromConstant->getName(),
+                var_export($fromValue, true),
+                var_export($toValue, true)
             ),
-        ]);
+            true
+        ));
     }
 }

src/DetectChanges/BCBreak/ClassConstantBased/ClassConstantVisibilityReduced.php

@@ -27,7 +27,7 @@ public function __invoke(ReflectionClassConstant $fromConstant, ReflectionClassC
             return Changes::empty();
         }
 
-        return Changes::fromArray([Change::changed(
+        return Changes::fromList(Change::changed(
             sprintf(
                 'Constant %s::%s visibility reduced from %s to %s',
                 $fromConstant->getDeclaringClass()->getName(),
@@ -36,8 +36,7 @@ public function __invoke(ReflectionClassConstant $fromConstant, ReflectionClassC
                 $visibilityTo
             ),
             true
-        ),
-        ]);
+        ));
     }
 
     private function propertyVisibility(ReflectionClassConstant $property) : string

src/DetectChanges/BCBreak/FunctionBased/ParameterByReferenceChanged.php

@@ -53,18 +53,16 @@ private function compareParameter(ReflectionParameter $fromParameter, Reflection
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'The parameter $%s of %s changed from %s to %s',
-                    $fromParameter->getName(),
-                    $this->formatFunction->__invoke($fromParameter->getDeclaringFunction()),
-                    $this->referenceToString($fromByReference),
-                    $this->referenceToString($toByReference)
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'The parameter $%s of %s changed from %s to %s',
+                $fromParameter->getName(),
+                $this->formatFunction->__invoke($fromParameter->getDeclaringFunction()),
+                $this->referenceToString($fromByReference),
+                $this->referenceToString($toByReference)
             ),
-        ]);
+            true
+        ));
     }
 
     private function referenceToString(bool $reference) : string

src/DetectChanges/BCBreak/FunctionBased/ParameterDefaultValueChanged.php

@@ -49,18 +49,16 @@ public function __invoke(ReflectionFunctionAbstract $fromFunction, ReflectionFun
                 continue;
             }
 
-            $changes = $changes->mergeWith(Changes::fromArray([
-                Change::changed(
-                    sprintf(
-                        'Default parameter value for for parameter $%s of %s changed from %s to %s',
-                        $parameter->getName(),
-                        $this->formatFunction->__invoke($fromFunction),
-                        var_export($defaultValueFrom, true),
-                        var_export($defaultValueTo, true)
-                    ),
-                    true
+            $changes = $changes->mergeWith(Changes::fromList(Change::changed(
+                sprintf(
+                    'Default parameter value for for parameter $%s of %s changed from %s to %s',
+                    $parameter->getName(),
+                    $this->formatFunction->__invoke($fromFunction),
+                    var_export($defaultValueFrom, true),
+                    var_export($defaultValueTo, true)
                 ),
-            ]));
+                true
+            )));
         }
 
         return $changes;

src/DetectChanges/BCBreak/FunctionBased/ParameterTypeChanged.php

@@ -55,18 +55,16 @@ private function compareParameter(ReflectionParameter $fromParameter, Reflection
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'The parameter $%s of %s changed from %s to %s',
-                    $fromParameter->getName(),
-                    $this->formatFunction->__invoke($fromParameter->getDeclaringFunction()),
-                    $fromType,
-                    $toType
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'The parameter $%s of %s changed from %s to %s',
+                $fromParameter->getName(),
+                $this->formatFunction->__invoke($fromParameter->getDeclaringFunction()),
+                $fromType,
+                $toType
             ),
-        ]);
+            true
+        ));
     }
 
     private function typeToString(?ReflectionType $type) : string

src/DetectChanges/BCBreak/FunctionBased/ParameterTypeContravarianceChanged.php

@@ -58,18 +58,16 @@ private function compareParameter(ReflectionParameter $fromParameter, Reflection
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'The parameter $%s of %s changed from %s to a non-contravariant %s',
-                    $fromParameter->getName(),
-                    $this->formatFunction->__invoke($fromParameter->getDeclaringFunction()),
-                    $this->typeToString($fromType),
-                    $this->typeToString($toType)
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'The parameter $%s of %s changed from %s to a non-contravariant %s',
+                $fromParameter->getName(),
+                $this->formatFunction->__invoke($fromParameter->getDeclaringFunction()),
+                $this->typeToString($fromType),
+                $this->typeToString($toType)
             ),
-        ]);
+            true
+        ));
     }
 
     private function typeToString(?ReflectionType $type) : string

src/DetectChanges/BCBreak/FunctionBased/RequiredParameterAmountIncreased.php

@@ -33,16 +33,14 @@ public function __invoke(ReflectionFunctionAbstract $fromFunction, ReflectionFun
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'The number of required arguments for %s increased from %d to %d',
-                    $this->formatFunction->__invoke($fromFunction),
-                    $fromRequiredParameters,
-                    $toRequiredParameters
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'The number of required arguments for %s increased from %d to %d',
+                $this->formatFunction->__invoke($fromFunction),
+                $fromRequiredParameters,
+                $toRequiredParameters
             ),
-        ]);
+            true
+        ));
     }
 }

src/DetectChanges/BCBreak/FunctionBased/ReturnTypeByReferenceChanged.php

@@ -33,17 +33,15 @@ public function __invoke(ReflectionFunctionAbstract $fromFunction, ReflectionFun
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'The return value of %s changed from %s to %s',
-                    $this->formatFunction->__invoke($fromFunction),
-                    $this->referenceToString($fromReturnsReference),
-                    $this->referenceToString($toReturnsReference)
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'The return value of %s changed from %s to %s',
+                $this->formatFunction->__invoke($fromFunction),
+                $this->referenceToString($fromReturnsReference),
+                $this->referenceToString($toReturnsReference)
             ),
-        ]);
+            true
+        ));
     }
 
     private function referenceToString(bool $reference) : string

src/DetectChanges/BCBreak/FunctionBased/ReturnTypeChanged.php

@@ -35,17 +35,15 @@ public function __invoke(ReflectionFunctionAbstract $fromFunction, ReflectionFun
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'The return type of %s changed from %s to %s',
-                    $this->formatFunction->__invoke($fromFunction),
-                    $fromReturnType,
-                    $toReturnType
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'The return type of %s changed from %s to %s',
+                $this->formatFunction->__invoke($fromFunction),
+                $fromReturnType,
+                $toReturnType
             ),
-        ]);
+            true
+        ));
     }
 
     private function typeToString(?ReflectionType $type) : string

src/DetectChanges/BCBreak/FunctionBased/ReturnTypeCovarianceChanged.php

@@ -40,17 +40,15 @@ public function __invoke(ReflectionFunctionAbstract $fromFunction, ReflectionFun
             return Changes::empty();
         }
 
-        return Changes::fromArray([
-            Change::changed(
-                sprintf(
-                    'The return type of %s changed from %s to the non-covariant %s',
-                    $this->formatFunction->__invoke($fromFunction),
-                    $this->typeToString($fromReturnType),
-                    $this->typeToString($toReturnType)
-                ),
-                true
+        return Changes::fromList(Change::changed(
+            sprintf(
+                'The return type of %s changed from %s to the non-covariant %s',
+                $this->formatFunction->__invoke($fromFunction),
+                $this->typeToString($fromReturnType),
+                $this->typeToString($toReturnType)
             ),
-        ]);
+            true
+        ));
     }
 
     private function typeToString(?ReflectionType $type) : string

src/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameClass.php

@@ -22,11 +22,10 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             return Changes::empty();
         }
 
-        return Changes::fromArray([Change::changed(
+        return Changes::fromList(Change::changed(
             sprintf('Interface %s became a class', $fromClass->getName()),
             true
-        ),
-        ]);
+        ));
     }
 
     /**

src/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameTrait.php

@@ -22,10 +22,9 @@ public function __invoke(ReflectionClass $fromClass, ReflectionClass $toClass) :
             return Changes::empty();
         }
 
-        return Changes::fromArray([Change::changed(
+        return Changes::fromList(Change::changed(
             sprintf('Interface %s became a trait', $fromClass->getName()),
             true
-        ),
-        ]);
+        ));
     }
 }