Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs how to use Github actions and docker #116

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Feb 3, 2019

I really like this tool. With some inspiration from PHPStan, I created this repo: https://github.com/Nyholm/roave-bc-check-docker

It builds docker images and support for Github actions.

This PR contains installation instructions that might be easier to use... however, I also understand if you only want to have a link saying: "If you use docker or github actions, go here ->"

screenshot 2019-02-03 at 09 47 36

@Ocramius
Copy link
Member

Ocramius commented Feb 3, 2019

The patch looks okay, but do you have automation to keep these images fresh/sync'd with tags?

@Nyholm
Copy link
Contributor Author

Nyholm commented Feb 3, 2019

Yes I do.

Docker build new images on every push to https://github.com/Nyholm/roave-bc-check-docker
Travis cron runs every day and will build new images.

The only manual work is if we release roave/backward-compatibility-check:3.0 and roave/backward-compatibility-check:4.0 people cannot specifically target the 3.0 version unless an update is made on my repo.

People can always use the latest stable release and latest (dev-master).
The github action is always using stable.

@Nyholm Nyholm changed the title Added docks how to use Github actions and docker Added docs how to use Github actions and docker Feb 3, 2019
@Ocramius
Copy link
Member

Ocramius commented Feb 3, 2019

Any way to also trigger the symc automatically?

@Nyholm
Copy link
Contributor Author

Nyholm commented Feb 3, 2019

Any way to also trigger the symc automatically?

If I can trigger the sync for major version automatically? I dont think so. As you can see in https://github.com/Nyholm/roave-bc-check-docker I need different docker file for each major version. I do also need to set up trigger rules on docker hub.

You could trigger it automatically by either
A) Use a private CI that build and pushes all major versions automatically. (needs my docker API key)
B) Move all the docker files from https://github.com/Nyholm/roave-bc-check-docker to this repo and configure docker hub to build the tags pushed to this repo.

@Ocramius
Copy link
Member

Ocramius commented Feb 3, 2019

Note that I'm asking these questions to reduce downstream maintenance. I don't want to land in the scenario (in which I personally already am, for other projects) where somebody needs to run around and do work that can be automated.

Move all the docker files from https://github.com/Nyholm/roave-bc-check-docker to this repo and configure docker hub to build the tags pushed to this repo.

Does docker not have scoped API keys? Also, would you be OK with being added as a contributor to the repo, if we moved the scope to something specifically created for this repo?

Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nyholm this is really awesome, love it! Strong +1 from me, pending Marco's concerns about maintenance :) thanks!

@Nyholm
Copy link
Contributor Author

Nyholm commented Feb 3, 2019

Im happy to maintain this separate library as it is.
Im also researching (fancy word for "thinking") of ways to make this 100% automatic.

@Ocramius Ocramius self-assigned this Feb 4, 2019
@Ocramius Ocramius added this to the 2.1.0 milestone Feb 4, 2019
@Ocramius
Copy link
Member

Ocramius commented Feb 4, 2019

I'm gonna go with "let's ship it", for now. @Nyholm I might merge your docker setup in here at some point (I also want to switch to github actions), but at a later point in time :-P

@Ocramius Ocramius merged commit 991bf55 into Roave:master Feb 4, 2019
@dkarlovi
Copy link
Contributor

@Nyholm Can't this repo setup a webhook to ping your Dockerhub?

@Nyholm Nyholm deleted the patch-1 branch February 11, 2019 14:30
@Ocramius
Copy link
Member

Yup, that's something I can set up here 👍

@Nyholm
Copy link
Contributor Author

Nyholm commented Feb 11, 2019

It is currently built every day. A webhook would sure help docker hub to spend too much resources. But a part from that it does not bring any value

@Ocramius
Copy link
Member

If it's already built every day, that's fine, no need to overdo it :)

@dkarlovi
Copy link
Contributor

The only difference I see is it would be available in sync with tagging here and not a day later.

@Ocramius
Copy link
Member

@dkarlovi meh, it's already good enough that I get to tag things every few months :P


action "Roave BC Check" {
uses = "docker://nyholm/roave-bc-check-ga"
secrets = ["GITHUB_TOKEN"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the secret is not needed. I did this for my github actions too, I didn’t write or use any github api endpoints in the image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants