-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docs how to use Github actions and docker #116
Conversation
The patch looks okay, but do you have automation to keep these images fresh/sync'd with tags? |
Yes I do. Docker build new images on every push to https://github.com/Nyholm/roave-bc-check-docker The only manual work is if we release People can always use the latest |
Any way to also trigger the symc automatically? |
If I can trigger the sync for major version automatically? I dont think so. As you can see in https://github.com/Nyholm/roave-bc-check-docker I need different docker file for each major version. I do also need to set up trigger rules on docker hub. You could trigger it automatically by either |
Note that I'm asking these questions to reduce downstream maintenance. I don't want to land in the scenario (in which I personally already am, for other projects) where somebody needs to run around and do work that can be automated.
Does docker not have scoped API keys? Also, would you be OK with being added as a contributor to the repo, if we moved the scope to something specifically created for this repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nyholm this is really awesome, love it! Strong +1 from me, pending Marco's concerns about maintenance :) thanks!
Im happy to maintain this separate library as it is. |
I'm gonna go with "let's ship it", for now. @Nyholm I might merge your docker setup in here at some point (I also want to switch to github actions), but at a later point in time :-P |
@Nyholm Can't this repo setup a webhook to ping your Dockerhub? |
Yup, that's something I can set up here 👍 |
It is currently built every day. A webhook would sure help docker hub to spend too much resources. But a part from that it does not bring any value |
If it's already built every day, that's fine, no need to overdo it :) |
The only difference I see is it would be available in sync with tagging here and not a day later. |
@dkarlovi meh, it's already good enough that I get to tag things every few months :P |
|
||
action "Roave BC Check" { | ||
uses = "docker://nyholm/roave-bc-check-ga" | ||
secrets = ["GITHUB_TOKEN"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the secret is not needed. I did this for my github actions too, I didn’t write or use any github api endpoints in the image
I really like this tool. With some inspiration from PHPStan, I created this repo: https://github.com/Nyholm/roave-bc-check-docker
It builds docker images and support for Github actions.
This PR contains installation instructions that might be easier to use... however, I also understand if you only want to have a link saying: "If you use docker or github actions, go here ->"