Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git error when running without --from option #72

Closed
ciaranmcnulty opened this issue May 27, 2018 · 2 comments
Closed

Git error when running without --from option #72

ciaranmcnulty opened this issue May 27, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@ciaranmcnulty
Copy link
Contributor

Steps to reproduce:

  1. check out phpspec/phpspec
  2. add this tool to composer requires and update
  3. run vendor/bin/roave-backward-compatibility-check

Error:

[Symfony\Component\Process\Exception\ProcessFailedException]                     
  The command "'git' 'rev-parse' ''" failed.                                       
                                                                                   
  Exit Code: 128(Invalid exit argument)

The input parameter --from is optional so its default value is NULL. this is explicitly cast to a string '' in AssertBackwardsCompatible::parseRevisionFromInput, but the implementation of GitParseRevision then builds a the CLI with an empty string, which breaks as above

@ciaranmcnulty ciaranmcnulty changed the title Git error when running against master branch Git error when running without --from May 27, 2018
@ciaranmcnulty ciaranmcnulty changed the title Git error when running without --from Git error when running without --from option May 27, 2018
@ciaranmcnulty
Copy link
Contributor Author

oh I see the problem, will PR

@Ocramius
Copy link
Member

Handled in #73

@Ocramius Ocramius self-assigned this May 27, 2018
@Ocramius Ocramius added the bug label May 27, 2018
@Ocramius Ocramius added this to the 1.0.2 milestone May 27, 2018
Ocramius added a commit that referenced this issue May 28, 2018
…OR* is picked

Previously, only the *MINOR* version was being compared, leading to previous major
versions being considered in the lookup for the lowest available stable release.
Ocramius added a commit that referenced this issue May 28, 2018
…itories

The reasoning behind this is that `symfony/console` has a very squishy API, and
that can lead to a lot of headaches in upgrades or implicit API changes.

Having an E2E test will ensure that the implementation details of `symfony/console`
are also considered, since the interfaces really just lie.
Ocramius added a commit that referenced this issue May 28, 2018
Ocramius added a commit that referenced this issue May 28, 2018
Ocramius added a commit that referenced this issue May 28, 2018
… comparisons on no valid detected versions
Ocramius added a commit that referenced this issue May 28, 2018
…d in the selected stable minor releases
Ocramius added a commit that referenced this issue May 28, 2018
Ocramius added a commit that referenced this issue Jun 4, 2018
Ocramius added a commit that referenced this issue Jun 4, 2018
…options

#66 #72 #73 fixed missing `--from` handling, minor version detection and scenario with no detected versions at all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants