-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git error when running without --from option #72
Comments
ciaranmcnulty
changed the title
Git error when running against master branch
Git error when running without May 27, 2018
--from
ciaranmcnulty
changed the title
Git error when running without
Git error when running without --from option
May 27, 2018
--from
oh I see the problem, will PR |
Handled in #73 |
Ocramius
added a commit
that referenced
this issue
May 28, 2018
…OR* is picked Previously, only the *MINOR* version was being compared, leading to previous major versions being considered in the lookup for the lowest available stable release.
Ocramius
added a commit
that referenced
this issue
May 28, 2018
…itories The reasoning behind this is that `symfony/console` has a very squishy API, and that can lead to a lot of headaches in upgrades or implicit API changes. Having an E2E test will ensure that the implementation details of `symfony/console` are also considered, since the interfaces really just lie.
Ocramius
added a commit
that referenced
this issue
May 28, 2018
Ocramius
added a commit
that referenced
this issue
May 28, 2018
… comparisons on no valid detected versions
Ocramius
added a commit
that referenced
this issue
May 28, 2018
…d in the selected stable minor releases
Ocramius
added a commit
that referenced
this issue
May 28, 2018
Ocramius
added a commit
that referenced
this issue
Jun 4, 2018
Ocramius
added a commit
that referenced
this issue
Jun 4, 2018
Ocramius
added a commit
that referenced
this issue
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
phpspec/phpspec
vendor/bin/roave-backward-compatibility-check
Error:
The input parameter
--from
is optional so its default value isNULL
. this is explicitly cast to a string''
inAssertBackwardsCompatible::parseRevisionFromInput
, but the implementation ofGitParseRevision
then builds a the CLI with an empty string, which breaks as aboveThe text was updated successfully, but these errors were encountered: