Skip to content

False-positive result on add nullable type in final method of abstract class #313

Open
@vjik

Description

Example:

abstract class X {
	final public function test(string $var): self
}

changed to:

abstract class X {
	final public function test(?string $var): self
}

result will be:

[BC] CHANGED: The parameter $var of X#test() changed from string to ?string

Real example: yiisoft/html#78

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions