Fix camel_to_snake_case for "v2x" (#594)

see issue mobilityhouse/ocpp#591
RoaringDev1203 · Feb 7, 2024 · 0596fe2 · 0596fe2
1 parent 91c21ea
commit 0596fe2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 - [#557](https://github.com/mobilityhouse/ocpp/issues/557) OCPP 2.0.1 Wrong data type in CostUpdated total_cost
 - [#564](https://github.com/mobilityhouse/ocpp/issues/564) Add support For Python 3.11 and 3.12
 - [#583](https://github.com/mobilityhouse/ocpp/issues/583) OCPP v1.6/v2.0.1 deprecate dataclasses from calls and call results with the suffix 'Payload'
+- [#591](https://github.com/mobilityhouse/ocpp/issues/591) Camel_to_snake_case doesn't handle v2x correctly
 - [#593](https://github.com/mobilityhouse/ocpp/issues/593) Update tests to use Call and CallResult without the suffix Payload
 
 ## 0.26.0 (2024-01-17)

diff --git a/ocpp/charge_point.py b/ocpp/charge_point.py
@@ -25,6 +25,7 @@ def camel_to_snake_case(data):
     if isinstance(data, dict):
         snake_case_dict = {}
         for key, value in data.items():
+            key = key.replace("V2X", "_v2x")
             s1 = re.sub("(.)([A-Z][a-z]+)", r"\1_\2", key)
             key = re.sub("([a-z0-9])([A-Z])(?=\\S)", r"\1_\2", s1).lower()
 

diff --git a/tests/test_charge_point.py b/tests/test_charge_point.py
@@ -52,6 +52,8 @@ def heartbeat(self, **kwargs):
     [
         ({"transactionId": "74563478"}, {"transaction_id": "74563478"}),
         ({"fullSoC": 100}, {"full_soc": 100}),
+        ({"evMinV2XEnergyRequest": 200}, {"ev_min_v2x_energy_request": 200}),
+        ({"v2xChargingCtrlr": 200}, {"v2x_charging_ctrlr": 200}),
     ],
 )
 def test_camel_to_snake_case(test_input, expected):