Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with TeXLive2020 kvoptions-patch conflict. #6

Closed
laenan8466 opened this issue Nov 27, 2020 · 20 comments
Closed

Error with TeXLive2020 kvoptions-patch conflict. #6

laenan8466 opened this issue Nov 27, 2020 · 20 comments
Assignees
Labels

Comments

@laenan8466
Copy link

Hey,
first thank you for the template. It is wonderful!

Sadly, with TexLive2020, it is not working anymore, as there is an issue with kvoptions-patch. I asked a related question on TeX stackexchange: https://tex.stackexchange.com/questions/572584/changes-from-texlive-2017-2020

I will try if I can find a solution, but not sure if I have the time.

Further resources on the issue:
kvoption package announcement concerning this issue
issue on github

@Roald87
Copy link
Owner

Roald87 commented Nov 27, 2020

Hey @laenan8466,

Glad to hear that my 3 year old template is still enjoyed by people!

Thanks for the investigation into the source of the problem! I will try to find a solution, but I haven't used LaTeX in some time, so I'll have to get into it again :).

Roald.

@Roald87 Roald87 self-assigned this Nov 27, 2020
@Roald87 Roald87 added the bug label Nov 27, 2020
@laenan8466
Copy link
Author

laenan8466 commented Nov 27, 2020

Hey,
it's me again. Of course people are working with it: Oldies but goodies... ;-)

I started working on a resolution, and faced a 'decision' that I have to make. Stumbled over it, as I was creating a new class (similar to your cv) for my cover letter. And I need your opinion:
Would you favor to change the compiler to lualatex or stay with xelatex? Just because I read in the TeX manual:
LuaTEXis the designated successor of pdfTEX

I have no strong opinion here, ...

EDIT: I played around a bit with LuaLaTeX. Although it is designated to be the future, I would recommend to continue using XeLaTex. I wasn't even able to run:

% !TeX program = lualatex
\documentclass{standalone}

\begin{document}
	Inhalt...
\end{document}

They manage the fonts from the system fonts and there is some issue on my (Windows) machine.

@u-fischer
Copy link

They manage the fonts from the system fonts and there is some issue on my (Windows) machine.

I have windows too, and lualatex works for me (and my other people) without any problems.

Beside this: nothing in the class is xelatex specific, it should work with lualatex too. But the class should remove the cellspace patch, cellspace has been adapted and contains the fix. And there is no need to load color if tikz is loaded.

@laenan8466
Copy link
Author

Thanks for stepping in! :-)
Most probably, it's sth amiss on my machine, as LuaLaTeX is working fine on my other one. Sadly, I just hadn't had the patience to fix it that day.
I will look into the cellspace tomorrow.
@Roald87 I had the feeling, that cellspace wasn't working for me properly, and I got quite narrow bottom lines. Did you expect the same thing?

@Roald87
Copy link
Owner

Roald87 commented Nov 29, 2020

I just tried to compile the example cv with different tex live versions (2020, 2019 and 2016) on Overleaf. I had no issues with the kvoptions-patch package when I tried to compile it. It worked for both XeLaTeX as well as LuaTex.

I'll also install tex locally on my Ubuntu machine and see if I can compile it there.

I did notice that the spacing after the titles was different with texlive 2020 and that the cellspace was not working properly. Regarding the latter: As mentioned by @u-fischer this can be fixed by removing the code in the patch section:

% # REQUIRED PACKAGES
\RequirePackage{xpatch}

% Patch to prevent package color and cellspace to clash
% More info: https://tex.stackexchange.com/questions/384664/xcolor-package-disables-cellspace-package
\makeatletter
\xpatchcmd{\@endpbox}{\color@endgroup}{\expandafter\color@endgroup}{}{\ddt}
\makeatother

@laenan8466
Copy link
Author

laenan8466 commented Nov 29, 2020

Hrm,
when your local install works fine as well, I guess it is my corrupted Windows installation...
Ah, didn't understood the part with the patch completely.
Could one add a conditional check for the TeXLive (?) version in the xpatch section?

@Roald87
Copy link
Owner

Roald87 commented Nov 29, 2020

Could one add an conditional check for the TeXLive (?) version in the xpatch section?

Not sure. Let me check.

@Roald87
Copy link
Owner

Roald87 commented Dec 20, 2020

Could one add an conditional check for the TeXLive (?) version in the xpatch section?

Couldn't find an easy method to do this unfortunately.

@laenan8466
Copy link
Author

Yep, I came to the same conclusion. For me I circumvent this by using an old latex version. If I update my version at any point and find a solution, I will let you know.

@j-jansen
Copy link

I had the same issue and I could solve it without changing to an old latex version but simply by replacing the package "kvoptions-patch" with "xkvltxp" in the .cls file. I did not have to change anything else.

@Roald87
Copy link
Owner

Roald87 commented Mar 24, 2021

Thanks for letting us know!

@laenan8466
Copy link
Author

Works for me as well as solution. Had to adjust some margins/spacings, but nothing big.

I'm just a little bit hesitant as there is a reason why people switched from xkvltxp to kvoptions-patch. Also it seems to be quite old, isn't it? Not sure, if it is still under maintenance.

But thank you! It worked for this problem and now I don't have to switch the computer to get a new date on my CV every time...

@Roald87
Copy link
Owner

Roald87 commented Apr 2, 2021

Docs were updated a few months ago, so looks like xkvltxp is still maintained.

afbeelding

@Freezeen
Copy link

Hey Guys, i just try to understand how this fix works, i use texworks and i really can not find this cls file.

I hope you can help me, this problem drives me crazy. :(

@Roald87
Copy link
Owner

Roald87 commented Jun 17, 2021

@Freezeen what cls file do you mean?

@Freezeen
Copy link

I had the same issue and I could solve it without changing to an old latex version but simply by replacing the package "kvoptions-patch" with "xkvltxp" in the .cls file. I did not have to change anything else.

I mean this one :) and thanks for the quick reply.

@Roald87
Copy link
Owner

Roald87 commented Jun 17, 2021

I had the same issue and I could solve it without changing to an old latex version but simply by replacing the package "kvoptions-patch" with "xkvltxp" in the .cls file. I did not have to change anything else.

I mean this one :) and thanks for the quick reply.

No problem. Glad the template is still used! It is line 59 of cv-roald.cls

@Freezeen
Copy link

Many thanks it works great <3 You saved me :)

@laenan8466
Copy link
Author

Close at this point as many solutions were given.

@laenan8466 laenan8466 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2023
@Roald87
Copy link
Owner

Roald87 commented Apr 7, 2024

Latest version 5.x.x works with TexLive 2023 on Overleaf. I do get an error that there are unused options, but all template options (changecolor, titlecolor, and colorharmony) work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants