Skip to content

Resolve DeprecationWarning: distutils #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

retornam
Copy link
Contributor

@retornam retornam commented Jun 1, 2023

distutils will be deprecated in python 3.12 [1]
This commit replaces distutils.StrictVersion with
the Version class from the packaging egg.

[1] https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated

fixes #13

distutils will be deprecated in python 3.12 [1]
This commit replaces distutils.StrictVersion with
the Version class from the packaging egg.

[1] https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated
Copy link

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 to the change for the deprecations, but would recommend removing the style changes and .gitignore to a separate PR, since they are not germane to the change as described.

I'm not a maintainer of this library, these are my opinions only ;)

@Roadmaster Roadmaster merged commit 730855e into Roadmaster:master Aug 11, 2023
@retornam
Copy link
Contributor Author

retornam commented Aug 11, 2023

@Roadmaster thanks. One small request, can you please tag releases on github too.

@retornam retornam deleted the retornam/strictfix branch August 11, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.10 and higher emits deprecation warning for upcoming Python 3.12
3 participants