Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect test vectors from the network for encoding / decoding #2

Closed
Rjected opened this issue Jun 14, 2022 · 1 comment
Closed

Collect test vectors from the network for encoding / decoding #2

Rjected opened this issue Jun 14, 2022 · 1 comment

Comments

@Rjected
Copy link
Owner

Rjected commented Jun 14, 2022

There should be plenty of test vectors for correct encoding / decoding of real network messages, to make sure the RlpEncodable and RlpDecodable derives work correctly, as well as any custom Encodable and Decodable implementations.

To do this, we should collect encodings from the network and attempt to decode them. We should also check that the correct byte strings are output, given known decoded messages.

@Rjected
Copy link
Owner Author

Rjected commented Jul 13, 2022

Closing since this has been done for a lot of messages, but more test vectors are always appreciated (especially failing test vectors).

@Rjected Rjected closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant