Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for state messages #3

Closed
Rjected opened this issue Jun 14, 2022 · 1 comment
Closed

Write tests for state messages #3

Rjected opened this issue Jun 14, 2022 · 1 comment

Comments

@Rjected
Copy link
Owner

Rjected commented Jun 14, 2022

The messages NodeData and GetNodeData should have encoding and decoding tests from the network, as part of the broader testing goal in #2.
@Rjected Rjected mentioned this issue Jun 15, 2022
Closed
45 tasks
@Rjected
Copy link
Owner Author

Rjected commented Jun 22, 2022

As of eth/67 state messages no longer exist, but eth/67 is a subset of eth/66 so supporting both will be very easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rjected