Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow computing estimators directly on a PMCSimulation #257

Merged
merged 12 commits into from
Jul 4, 2024
Merged

Allow computing estimators directly on a PMCSimulation #257

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c54580d
Allow computing estimators directly on a PMCSimulation
mtsch May 23, 2024
45eb072
Fix reweighting arguments
mtsch Jun 7, 2024
978305e
Fix problems with dtau
mtsch Jun 7, 2024
7ec4a2a
Change how time step is determined
mtsch Jun 24, 2024
b66b0e0
Fixup docstrings
mtsch Jun 24, 2024
795584c
fix reference in docstring
mtsch Jun 24, 2024
d517244
Make sure sparse is defined in test
mtsch Jun 24, 2024
d10fa93
remove dep in test
mtsch Jun 24, 2024
773efb1
Update docstrings
mtsch Jun 30, 2024
13ad1f1
Fix doc links, index.md
mtsch Jun 30, 2024
bed276b
Fix more doc links
mtsch Jun 30, 2024
3cbd422
growth_witness docstring tweak
mtsch Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix reweighting arguments
  • Loading branch information
@mtsch
mtsch committed Jul 4, 2024
commit 45eb072c748811a91d59e051b201a665186264ba
3 changes: 2 additions & 1 deletion src/StatsTools/reweighting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ function rayleigh_replica_estimator(
return ratio_of_means(num, denom; kwargs...)
end
function rayleigh_replica_estimator(
df::DataFrame;
sim;
shift_name="shift",
op_name="Op1",
vec_name="dot",
Expand All @@ -507,6 +507,7 @@ function rayleigh_replica_estimator(
Anorm=1,
kwargs...
)
df = DataFrame(sim)
num_reps = length(filter(startswith("dτ"), names(df)))
dτ = if num_reps == 1
df.dτ[end]
Expand Down