Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formula in HubbardRealSpace documentation #226

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mtsch
Copy link
Collaborator

@mtsch mtsch commented Nov 30, 2023

No description provided.

@mtsch mtsch requested a review from joachimbrand November 30, 2023 12:55
@coveralls
Copy link

coveralls commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7046760435

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 94.892%

Files with Coverage Reduction New Missed Lines %
src/BitStringAddresses/sortedparticlelist.jl 1 87.74%
Totals Coverage Status
Change from base Build 7027396917: -0.02%
Covered Lines: 5778
Relevant Lines: 6089

💛 - Coveralls

Copy link
Contributor

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Rimu.jl/Rimu.jl

Job Properties

  • Time of benchmarks:
  • Target: 30 Nov 2023 - 13:08
  • Baseline: 30 Nov 2023 - 13:19
  • Package commits:
  • Target: 7551f8
  • Baseline: 55ffbc
  • Julia commits:
  • Target: 8e5136
  • Baseline: 8e5136
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["Rimu", "Exact", "Diagonalization"]
  • ["Rimu", "Exact", "Multiplication"]
  • ["Rimu", "FCIQMC"]

Julia versioninfo

Target

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3242 MHz 2671 s 0 s 181 s 5843 s 0 s
 #2 2445 MHz 3801 s 0 s 142 s 4757 s 0 s
 #3 2662 MHz 2115 s 0 s 178 s 6404 s 0 s
 #4 2877 MHz 1558 s 0 s 199 s 6932 s 0 s
 Memory: 15.606895446777344 GB (13937.59765625 MB free)
 Uptime: 873.21 sec
 Load Avg: 1.0 1.02 0.77
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3242 MHz 4546 s 0 s 211 s 10175 s 0 s
 #2 2445 MHz 6771 s 0 s 169 s 8000 s 0 s
 #3 2582 MHz 3142 s 0 s 221 s 11569 s 0 s
 #4 2445 MHz 1925 s 0 s 256 s 12742 s 0 s
 Memory: 15.606895446777344 GB (13898.4765625 MB free)
 Uptime: 1497.85 sec
 Load Avg: 1.0 1.0 0.91
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Target result

Benchmark Report for /home/runner/work/Rimu.jl/Rimu.jl

Job Properties

  • Time of benchmark: 30 Nov 2023 - 13:8
  • Package commit: 7551f8
  • Julia commit: 8e5136
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["Rimu", "Exact", "Diagonalization", "2D Hubbard"] 1.773 s (5%) 2.636 ms 93.86 MiB (1%) 28407
["Rimu", "Exact", "Diagonalization", "Bose-Hubbard in momentum space"] 17.242 s (5%) 47.464 ms 367.26 MiB (1%) 2045216
["Rimu", "Exact", "Multiplication", "Momentum space"] 810.698 ms (5%) 10.92 MiB (1%) 255
["Rimu", "Exact", "Multiplication", "Transcorrelated"] 2.832 s (5%) 1.88 MiB (1%) 255
["Rimu", "FCIQMC", "(10, 20) Mom space with projected energy and initiator"] 27.089 s (5%) 31.261 ms 52.71 MiB (1%) 1702777
["Rimu", "FCIQMC", "(4+1, 11) 2C Mom space with G2Correlators"] 25.614 s (5%) 32.46 MiB (1%) 853664
["Rimu", "FCIQMC", "(50, 50) Real space"] 21.514 s (5%) 29.57 MiB (1%) 142450

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["Rimu", "Exact", "Diagonalization"]
  • ["Rimu", "Exact", "Multiplication"]
  • ["Rimu", "FCIQMC"]

Julia versioninfo

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3242 MHz 2671 s 0 s 181 s 5843 s 0 s
 #2 2445 MHz 3801 s 0 s 142 s 4757 s 0 s
 #3 2662 MHz 2115 s 0 s 178 s 6404 s 0 s
 #4 2877 MHz 1558 s 0 s 199 s 6932 s 0 s
 Memory: 15.606895446777344 GB (13937.59765625 MB free)
 Uptime: 873.21 sec
 Load Avg: 1.0 1.02 0.77
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Baseline result

Benchmark Report for /home/runner/work/Rimu.jl/Rimu.jl

Job Properties

  • Time of benchmark: 30 Nov 2023 - 13:19
  • Package commit: 55ffbc
  • Julia commit: 8e5136
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["Rimu", "Exact", "Diagonalization", "2D Hubbard"] 1.775 s (5%) 2.228 ms 93.86 MiB (1%) 28407
["Rimu", "Exact", "Diagonalization", "Bose-Hubbard in momentum space"] 17.268 s (5%) 40.921 ms 367.26 MiB (1%) 2045216
["Rimu", "Exact", "Multiplication", "Momentum space"] 817.079 ms (5%) 10.92 MiB (1%) 255
["Rimu", "Exact", "Multiplication", "Transcorrelated"] 2.831 s (5%) 1.88 MiB (1%) 255
["Rimu", "FCIQMC", "(10, 20) Mom space with projected energy and initiator"] 27.207 s (5%) 25.499 ms 52.71 MiB (1%) 1702917
["Rimu", "FCIQMC", "(4+1, 11) 2C Mom space with G2Correlators"] 24.962 s (5%) 13.104 ms 32.46 MiB (1%) 853671
["Rimu", "FCIQMC", "(50, 50) Real space"] 21.975 s (5%) 29.57 MiB (1%) 142472

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["Rimu", "Exact", "Diagonalization"]
  • ["Rimu", "Exact", "Multiplication"]
  • ["Rimu", "FCIQMC"]

Julia versioninfo

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1016-azure #16~22.04.1-Ubuntu SMP Tue Oct 10 17:11:51 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3242 MHz 4546 s 0 s 211 s 10175 s 0 s
 #2 2445 MHz 6771 s 0 s 169 s 8000 s 0 s
 #3 2582 MHz 3142 s 0 s 221 s 11569 s 0 s
 #4 2445 MHz 1925 s 0 s 256 s 12742 s 0 s
 Memory: 15.606895446777344 GB (13898.4765625 MB free)
 Uptime: 1497.85 sec
 Load Avg: 1.0 1.0 0.91
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.85
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@yangmr04
Copy link
Collaborator

Do we want to name branches related to this kind of doc-only fix docfix instead of bugfix in the future? Because they are not actually bugs.

Copy link
Collaborator

@joachimbrand joachimbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@joachimbrand
Copy link
Collaborator

Do we want to name branches related to this kind of doc-only fix docfix instead of bugfix in the future? Because they are not actually bugs.

We already have it set up that branches called doc/** are bypassing the usual test suite. I suggest that in future we use that for documentation-only changes.

@mtsch mtsch merged commit 6ee298e into develop Dec 1, 2023
@joachimbrand joachimbrand deleted the bugfix/fix-hubbardrealspace-doc branch December 1, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants