Test cleanup and typo fixes #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Current coverage for BonMot.framework is
|
| Files changed | - | - |
|---|---|---|
| AdaptableTextContainer.swift | 41.67% |
🚫 |
| AdaptiveStyle.swift | 75.00% |
|
| StyleableUIElement.swift | 76.09% |
|
| NSAttributedString+Adaptive.swift | 90.38% |
✅ |
| XMLBuilder.swift | 96.59% |
✅ |
| FontFeatures.swift | 97.83% |
✅ |
| Composable.swift | 98.59% |
✅ |
| Tab.swift | 98.89% |
✅ |
Powered by xcov
Generated by 🚫 Danger
chrisballinger
approved these changes
Mar 14, 2021
Contributor
chrisballinger
left a comment
chrisballinger
left a comment
There was a problem hiding this comment.
Thank you! I think the breaking change is minor enough to not need a major version bump, but we should at least bump the minor version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only interesting thing (and calling it interesting is probably a stretch) is the commit that fixes a typo in public API by deprecating and renaming it. Please let me know if you think I've done it in a good way, and whether it constitutes a breaking change. (If the latter, we might as well just rename it and skip the deprecation.) It's a tricky case because the renamed parameter has a defaulted value, so consumers may not even be aware that there was a typo.