Simplify StringStyle.update(part:) switch statement #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2020 18:34
https://bugs.swift.org/browse/SR-2 was resolved in Swift 4.1. In order to fix #345, we need to remove support for Swift 4.0. We could add support for Swift 4.1, but I believe it’s better to increase the minimum version directly to Swift 4.2 because BonMot already officially supports and runs CI on Swift 4.2.
https://bugs.swift.org/browse/SR-2 was resolved in Swift 4.1. That allows simplifying the switch statement in StringStyle.update(part:) to remove nested switches, defaults, and fatal errors. Fixes #345.
Contributor
Author
|
Awesome, feel free to merge! I don’t have write access to this repo so I can’t. |
chrisballinger
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #381 because GitHub won’t let me reopen it. Fixes #345.
Simplifies the
switchstatement inStringStyle.update(part:)using the improved interaction between switch and #if in Swift 4.1+. This requires removing Swift 4.0 from the supported versions. I think it’s better not to add new support for Swift 4.1, so that would make the minimum version Swift 4.2.