Skip to content

Conversation

@ZevEisenberg
Copy link
Collaborator

@ZevEisenberg ZevEisenberg commented Sep 9, 2019

Way of the future

@raizlabs-oss-bot
Copy link
Collaborator

raizlabs-oss-bot commented Sep 9, 2019

1 Warning
⚠️ Big PR
2 Messages
📖 Test Results
📖 Code Coverage

Current coverage for BonMot.framework is 78.22%

Files changed - -
UIKit+AdaptableTextContainerSupport.swift 0.00% 💀
AdaptableTextContainer.swift 41.67% 🚫
UIKit+Helpers.swift 62.86% ⚠️
StyleableUIElement.swift 76.09% ⚠️
AdaptiveStyle.swift 82.84%
Tracking+Adaptive.swift 83.33%
NSAttributedString+Adaptive.swift 90.38%
Tab+Adaptive.swift 96.15%
EmbeddedTransformation.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

@DomAmato
Copy link

DomAmato commented Oct 7, 2019

This resolved for me and properly grabbed the files.
.package(url: "https://github.com/Rightpoint/BonMot.git", .branch("feature/zeveisenberg/swiftpm")),

Let me know if there is more to testing this than that but everything seems to be rendering as expected

@rainhead
Copy link

rainhead commented Jan 2, 2020

Thanks for maintaining the branch while this PR is open.

Copy link
Contributor

@chrisballinger chrisballinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests finally pass!

@chrisballinger
Copy link
Contributor

The status checks are stale, going to close and reopen.

@chrisballinger chrisballinger merged commit f1082f1 into master Feb 1, 2020
@chrisballinger chrisballinger deleted the feature/zeveisenberg/swiftpm branch February 1, 2020 01:46
@j-f1
Copy link

j-f1 commented Feb 2, 2020

@chrisballinger​/@ZevEisenberg can you re-tag 5.5 as 5.5.0? Xcode won’t pick it up otherwise.

The package dependency graph can not be resolved; unable find any available tag for the following requirements:

https://github.com/Rightpoint/BonMot — 5.5.0..<6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants