Skip to content

Conversation

@ZevEisenberg
Copy link
Collaborator

Fixes #339, plus one other minor fix for something that's been bothering me. @thisisjeffwong I'd appreciate a review of this, if you have time.

@ZevEisenberg
Copy link
Collaborator Author

Code I used to generated this, in case its useful to someone, including me from the future:
Dynamic Type Research.zip

@raizlabs-oss-bot
Copy link
Collaborator

raizlabs-oss-bot commented Jun 1, 2018

2 Messages
📖 Test Results
📖 Code Coverage

Current coverage for BonMot.framework is 82.66%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

@thisisjeffwong
Copy link

The graph shows most of the styles not growing in the larger accessibility sizes. However, I noticed that they still do when looking at the Apple typography docs.

I'm not sure which is correct though it doesn't make sense to me why they would have some sizes simply not grow.

I didn't notice the discrepancy before when I filed the ticket.

Copy link

@thisisjeffwong thisisjeffwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here: #340 (comment)

@ZevEisenberg
Copy link
Collaborator Author

I only updated the two new sizes. I guess I should update all the sizes, just in case they’ve changed. I really should throw together a script that can do this all via a graphing library or something.

@ZevEisenberg ZevEisenberg force-pushed the bugfix/readme-updates branch 2 times, most recently from 9548e33 to 3461861 Compare September 19, 2018 18:54
@ZevEisenberg ZevEisenberg force-pushed the bugfix/readme-updates branch from 63af6c8 to fca7643 Compare January 26, 2019 18:08
@cjamie
Copy link

cjamie commented Jun 2, 2019

can we also include changing the struct Constants in this PR to enum Constants since its more appropriate as a namespace

@ZevEisenberg
Copy link
Collaborator Author

@cjamie which constants are those? I don’t think it’s related to this PR; would you mind opening a new PR or issue with more detail?

@cjamie
Copy link

cjamie commented Jun 4, 2019

@ZevEisenberg the ones in the readme

@chrisballinger chrisballinger merged commit 64ca2b3 into master Jun 30, 2021
@chrisballinger chrisballinger deleted the bugfix/readme-updates branch June 30, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaling Behavior graph does not plot the Apple Dynamic Type behaviors as implied

7 participants