-
Notifications
You must be signed in to change notification settings - Fork 197
Readme updates #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme updates #340
Conversation
|
Code I used to generated this, in case its useful to someone, including me from the future: |
Current coverage for BonMot.framework is
|
|
The graph shows most of the styles not growing in the larger accessibility sizes. However, I noticed that they still do when looking at the Apple typography docs. I'm not sure which is correct though it doesn't make sense to me why they would have some sizes simply not grow. I didn't notice the discrepancy before when I filed the ticket. |
thisisjeffwong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment here: #340 (comment)
|
I only updated the two new sizes. I guess I should update all the sizes, just in case they’ve changed. I really should throw together a script that can do this all via a graphing library or something. |
9548e33 to
3461861
Compare
65e6475 to
60f31b0
Compare
60f31b0 to
63af6c8
Compare
63af6c8 to
fca7643
Compare
|
can we also include changing the |
|
@cjamie which constants are those? I don’t think it’s related to this PR; would you mind opening a new PR or issue with more detail? |
|
@ZevEisenberg the ones in the readme |
Fixes #339, plus one other minor fix for something that's been bothering me. @thisisjeffwong I'd appreciate a review of this, if you have time.