Skip to content

Conversation

@pmthomps
Copy link

This potentially breaks generate-hackmd-links library because there's
no more single/default module export.

Treat this PR as a starting point for conversation on how to better integrate with the existing library.

This potentially breaks generate-hackmd-links library because there's
no more single/default module export.
@RichardLitt
Copy link
Owner

Hey @pmthomps - I haven't had the resources to set aside time to test this PR correctly. I'm not opposed to just having a new version put on top if the old one doesn't work very well.

At the moment, this doesn't seem to work for me:

07:18 ~/src/generate-hackmd-links (pmthomps-issue-1) * 🐕  node cli.js --help
module.js:540
    throw err;
    ^

Error: Cannot find module 'socket.io-client'

Any thoughts?

@pmthomps
Copy link
Author

pmthomps commented Apr 25, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants