Skip to content

Conversation

@luedigernet
Copy link

I've used your fork instead of the original one because I liked the idea of DecodeEmbedded. But unfortunately it failed in the very first use of that function because map structure isn't able to handle time.Time fields out of the box.

For me it was much easier to add the functionality here instead of filling the gap in map structure.
I'll appreciate it if you will merge it into your fork.

kind regards

Reinhard

@codecov-io
Copy link

codecov-io commented Sep 27, 2017

Codecov Report

Merging #1 into master will decrease coverage by 7.85%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage      90%   82.14%   -7.86%     
==========================================
  Files           1        1              
  Lines          40       56      +16     
==========================================
+ Hits           36       46      +10     
- Misses          2        5       +3     
- Partials        2        5       +3
Impacted Files Coverage Δ
jsonhal.go 82.14% <63.15%> (-7.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05ce96...bce3985. Read the comment docs.

@RichardKnop RichardKnop merged commit 6fa3f8f into RichardKnop:master Sep 27, 2017
@RichardKnop
Copy link
Owner

@luedigernet Thanks for PR. Merged. Yes this version under my personal account is more actively maintained (similar to https://github.com/RichardKnop/go-fixtures which is also quite ahead of original repo already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants