fixed lags caused by ghasts in high distances #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you test and confirm this works? i don't really understand how the change fixes the problem, but maybe i'm missing something. |
i tested it and it works. you can check it by teleporing to12550800 in the nether and moving deeper into farlands(which caused the test server to freeze for 49 seconds without this patch) |
|
alrighty, awesome. i'll go ahead and merge it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lags were caused by the loop in
EntityGhast::awhich used distance from entity to 0/0/0 after spawning(d3).If the ghast spawned far from 0/0/0 (in farlands, for example), it would have to get entities ~12m times.