Fix missing line return when viewing dumps #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, `isprint()` claims that `0xff` is printable. But it's used by print functions as a magic value to suppress the line return. So when viewing a dump where the last byte of a block/sector is `0xff`, it was suppressing the new line between blocks/sectors. Signed-off-by: Jean-Michel Picod <jmichel.p@gmail.com>
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Great catch! I wouldn't have thought that one. the 0xFF as a marker might not be documented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
isprint()claims that0xffis printable. But it's used byPrintAndLogfunctions as a marker value to suppress the line return.So when viewing a dump where the last byte of a block/sector is
0xff, it was suppressing the new line between blocks/sectors. This fixes it by excluding0xfffrom printable values.