fix hf mfu pwdgen for 7 byte uid #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last 3 bytes of the 7 byte uid are zeroed out Tested with the example from the forum http://www.proxmark.org/forum/viewtopic.php?pid=44238#p44238 Signed-off-by: Anton Todorov <ANTodorov@users.noreply.github.com>
|
You are welcome to add an entry to the CHANGELOG.md as well |
add line for the `hf mfu pwdgen` fix Signed-off-by: Anton Todorov <ANTodorov@users.noreply.github.com>
|
I believe the correct flow would be if uidlen == 4 then zero out and adapt uidlen. |
|
It was my initial fix, but then I've saw that the uid is initialized with zeroes at the creation If you prefer the exact check against 4-byte I'll push an update asap. |
|
ah, uid len is not updated... I see yep. updating |
Signed-off-by: Anton Todorov <ANTodorov@users.noreply.github.com>
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last 3 bytes of the 7 byte uid are zeroed out
Tested with the example from the forum http://www.proxmark.org/forum/viewtopic.php?pid=44238#p44238