Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the timeout of TCP connections #2022

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

wh201906
Copy link
Contributor

@wh201906 wh201906 commented Jul 4, 2023

I just found that the timeout of TCP connections is overwritten in TestProxmark()
Here is the test output

Details
[=] Using UART port tcp:192.168.0.1:1234
Current timeout(us):500000
...
Current timeout(us):500000
[=] Communicating with PM3 over USB-CDC over TCP


  8888888b.  888b     d888  .d8888b.   
  888   Y88b 8888b   d8888 d88P  Y88b  
  888    888 88888b.d88888      .d88P  
  888   d88P 888Y88888P888     8888"  
  8888888P"  888 Y888P 888      "Y8b.  
  888        888  Y8P  888 888    888  
  888        888   "   888 Y88b  d88P 
  888        888       888  "Y8888P"    [ ☕ ]


Current timeout(us):20000
...
Current timeout(us):20000
  [ Proxmark3 RFID instrument ]

Current timeout(us):20000
...
Current timeout(us):20000
[!] ⚠️  Received packet frame with variable part too short? 182/412
Current timeout(us):20000
Current timeout(us):20000

@wh201906
Copy link
Contributor Author

wh201906 commented Jul 4, 2023

Here is the test output after this fix

Details
[=] Using UART port tcp:192.168.0.1:1234
Current timeout(us):500000
...
Current timeout(us):500000
[=] Communicating with PM3 over USB-CDC over TCP


  8888888b.  888b     d888  .d8888b.   
  888   Y88b 8888b   d8888 d88P  Y88b  
  888    888 88888b.d88888      .d88P  
  888   d88P 888Y88888P888     8888"  
  8888888P"  888 Y888P 888      "Y8b.  
  888        888  Y8P  888 888    888  
  888        888   "   888 Y88b  d88P 
  888        888       888  "Y8888P"    [ ☕ ]


Current timeout(us):500000
  [ Proxmark3 RFID instrument ]

Current timeout(us):500000
...
Current timeout(us):500000
    MCU....... AT91SAM7S512 Rev B
    Memory.... 512 KB ( 67% used )

    Client.... Iceman/dev/v4.16717-18-g5de6fa44-dirty 2023-07-04 16:30:18
    Bootrom... Iceman/master/v4.16717-9-gadfebd651 2023-06-26 21:52:08 
    OS........ Iceman/master/v4.16717 2023-06-26 13:10:45 
    Target.... PM3 GENERIC


[!] ⚠️   --> ARM firmware does not match the source at the time the client was compiled
[!] ⚠️   --> Make sure to flash a correct and up-to-date version

[usb] pm3 --> Current timeout(us):500000
Current timeout(us):500000
Current timeout(us):500000

@iceman1001 iceman1001 merged commit 9c947ed into RfidResearchGroup:master Jul 5, 2023
12 checks passed
@iceman1001
Copy link
Collaborator

Nice catch!

Thanks

@wh201906 wh201906 deleted the tcp_timeout branch July 5, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants